Extract multiple windows + dock and menu accessibilities #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshamrai
requested changes
Oct 13, 2025
| for w in wins: | ||
| if int(w.get("kCGWindowLayer", 0)) != 0: | ||
| continue | ||
| owner = (w.get("kCGWindowOwnerName") or "").strip() |
There was a problem hiding this comment.
w.get("kCGWindowOwnerName") or "" -> w.get("kCGWindowOwnerName", "")
| screenshot_tmp_file.close() | ||
|
|
||
|
|
||
| import macapptree.screenshot_app_window as screenshot_app_window |
| # "window_info": win, | ||
| # "tree": tree.to_dict() | ||
| # }) | ||
| # return trees |
There was a problem hiding this comment.
Delete redundant comments
|
|
||
|
|
||
|
|
||
| if __name__ == "__main__": |
| except Exception: | ||
| pass | ||
|
|
||
| import subprocess, AppKit |
| return pid_to_bundle, bundle_to_app | ||
|
|
||
|
|
||
| def get_visible_windows_for_bundles(bundle_ids: List[str]) -> List[Dict]: |
There was a problem hiding this comment.
Why is it in this module?
| self.visible = False | ||
| if self.visible_bbox: | ||
| vx1, vy1, vx2, vy2 = self.visible_bbox | ||
| self.visible = (vx2 > vx1) and (vy2 > vy1) |
There was a problem hiding this comment.
It is already checked in the _set_bboxes
| if not vb: | ||
| return False | ||
| x1, y1, x2, y2 = vb | ||
| return (x2 > x1) and (y2 > y1) |
| return segment_image_path | ||
|
|
||
|
|
||
| def _is_visible(elem) -> bool: |
There was a problem hiding this comment.
Better make it a property of an object
| # open the image and create a drawer | ||
| draw = image_drawer | ||
| image = image | ||
| img = image |
|
Also, add in readme how to use your feature |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example of screen with dock + upper menu accessibility:
