Migrate XML configuration to PHP

README.md

@@ -74,7 +74,7 @@ Create Symfony Health Check Bundle Routing Config:
 
 ```yaml
 health_check:
-    resource: '@SymfonyHealthCheckBundle/Resources/config/routes.xml'
+    resource: '@SymfonyHealthCheckBundle/Resources/config/routes.php'
 ```
 
 Step 3: Configuration

src/DependencyInjection/SymfonyHealthCheckExtension.php

@@ -9,7 +9,7 @@
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Reference;
 use Symfony\Component\DependencyInjection\Extension\Extension;
-use Symfony\Component\DependencyInjection\Loader\XmlFileLoader;
+use Symfony\Component\DependencyInjection\Loader\PhpFileLoader;
 use SymfonyHealthCheckBundle\Controller\HealthController;
 use SymfonyHealthCheckBundle\Controller\PingController;
 
@@ -20,8 +20,8 @@ public function load(array $configs, ContainerBuilder $container): void
         $configuration = new Configuration();
         $config = $this->processConfiguration($configuration, $configs);
 
-        $loader = new XmlFileLoader($container, new FileLocator(__DIR__ . '/../Resources/config'));
-        $loader->load('controller.xml');
+        $loader = new PhpFileLoader($container, new FileLocator(__DIR__ . '/../Resources/config'));
+        $loader->load('controller.php');
 
         $this->loadHealthChecks($config, $loader, $container);
 
@@ -31,10 +31,10 @@ public function load(array $configs, ContainerBuilder $container): void
 
     private function loadHealthChecks(
         array $config,
-        XmlFileLoader $loader,
+        PhpFileLoader $loader,
         ContainerBuilder $container
     ): void {
-        $loader->load('health_checks.xml');
+        $loader->load('health_checks.php');
 
         $healthCheckCollection = $container->findDefinition(HealthController::class);
 

src/Resources/config/controller.php

@@ -0,0 +1,25 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Symfony\Component\DependencyInjection\Loader\Configurator;
+
+use SymfonyHealthCheckBundle\Controller\HealthController;
+use SymfonyHealthCheckBundle\Controller\PingController;
+
+return static function (ContainerConfigurator $container) {
+    $services = $container->services();
+    $parameters = $container->parameters();
+
+    $services->defaults()
+        ->autowire()
+        ->autoconfigure();
+
+    $services->set(HealthController::class, HealthController::class)
+        ->public()
+        ->tag('container.service_subscriber');
+
+    $services->set(PingController::class, PingController::class)
+        ->public()
+        ->tag('container.service_subscriber');
+};

src/Resources/config/health_checks.php

@@ -0,0 +1,47 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Symfony\Component\DependencyInjection\Loader\Configurator;
+
+use SymfonyHealthCheckBundle\Adapter\RedisAdapterWrapper;
+use SymfonyHealthCheckBundle\Check\DoctrineODMCheck;
+use SymfonyHealthCheckBundle\Check\DoctrineORMCheck;
+use SymfonyHealthCheckBundle\Check\EnvironmentCheck;
+use SymfonyHealthCheckBundle\Check\RedisCheck;
+use SymfonyHealthCheckBundle\Check\StatusUpCheck;
+
+return static function (ContainerConfigurator $container) {
+    $services = $container->services();
+    $parameters = $container->parameters();
+
+    $services->defaults()
+        ->public()
+        ->autowire()
+        ->autoconfigure();
+
+    $services->set('symfony_health_check.redis_adapter_wrapper', RedisAdapterWrapper::class)
+        ->private();
+
+    $services->set('symfony_health_check.doctrine_check', DoctrineORMCheck::class)
+        ->args([service('service_container')])
+        ->deprecate(
+            'macpaw/symfony-health-check-bundle',
+            '1.4.2',
+            'The "%service_id%" service alias is deprecated, use symfony_health_check.doctrine_orm_check instead'
+        );
+
+    $services->set('symfony_health_check.doctrine_orm_check', DoctrineORMCheck::class)
+        ->args([service('service_container')]);
+
+    $services->set('symfony_health_check.doctrine_odm_check', DoctrineODMCheck::class)
+        ->args([service('service_container')]);
+
+    $services->set('symfony_health_check.redis_check', RedisCheck::class)
+        ->args([service('symfony_health_check.redis_adapter_wrapper')]);
+
+    $services->set('symfony_health_check.environment_check', EnvironmentCheck::class)
+        ->args([service('service_container')]);
+
+    $services->set('symfony_health_check.status_up_check', StatusUpCheck::class);
+};

src/Resources/config/routes.php

@@ -0,0 +1,19 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Symfony\Component\DependencyInjection\Loader\Configurator;
+
+use Symfony\Component\Routing\Loader\Configurator\RoutingConfigurator;
+use SymfonyHealthCheckBundle\Controller\HealthController;
+use SymfonyHealthCheckBundle\Controller\PingController;
+
+return function (RoutingConfigurator $routes): void {
+    $routes->add('health', '/health')
+        ->controller([HealthController::class, 'check'])
+        ->methods(['GET']);
+
+    $routes->add('ping', '/ping')
+        ->controller([PingController::class, 'check'])
+        ->methods(['GET']);
+};

tests/config.yml

@@ -1,5 +1,5 @@
 framework:
     secret: secret
     router:
-        resource: "%kernel.project_dir%/Resources/config/routes.xml"
+        resource: "%kernel.project_dir%/Resources/config/routes.php"
     test: ~