PositivityToricBundles for JSAG - #4671
Draft
a-hochenegger wants to merge 1 commit into
Draft
Conversation
By d-torrance: Verbosity is not exported anymore (as exported by Core) Options DrawCohomology, DrawChernCharacter are not anymore protected, as this happens automatically By ggsmith: Removed unnecessary parentheses, added TypicalValue Replaced 'numgens source Matrix' by 'numColumns Matrix' Replaced 'instance(mat_(0,0),QQ)' by 'ring mat === QQ' In method 'primitive' lift matmod to ZZ and use 'matmod //m' Use table for 'cartesianProduct' Additionally: Rewrote 'cartesianProduct' as it caused a problem in separatesJets (reported by Nathan Ilten) Added test for that bug Updated Version number, date and contributors
d-torrance
marked this pull request as draft
August 31, 2026 08:42
d-torrance
added
JSAG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately, I've messed up my pull request #4135 by deleting the repository by mistake. I am very sorry for this and I want to apologize if this causes confusion.
This pull request contains all the changes that made for #4135. Additionally, Nathan Ilten reported a bug in the method 'isGloballyGenerated', that turned out to be a bug in 'cartesianProduct'. This bug has also been fixed for this pull request.
Here the complete list of changes:
By d-torrance:
Verbosity is not exported anymore (as exported by Core) Options DrawCohomology, DrawChernCharacter are not anymore protected, as this happens automatically
By ggsmith:
Removed unnecessary parentheses, added TypicalValue
Replaced 'numgens source Matrix' by 'numColumns Matrix'
Replaced 'instance(mat_(0,0),QQ)' by 'ring mat === QQ'
In method 'primitive' lift matmod to ZZ and use 'matmod //m'
Use table for 'cartesianProduct'
Additionally:
Rewrote 'cartesianProduct' as it caused a problem in separatesJets (reported by Nathan Ilten)
Added test for that bug
Updated Version number, date and contributors