Add NUnit test project and abstract BLE layer behind interfaces#1
Merged
Conversation
Introduces IBluetoothDevice / IBluetoothHost so ElkBledomScanner and ElkBledomDevice can be unit-tested without real hardware. Production callers default to the new InTheHand adapters under src/Claudelk.Core/Bluetooth/InTheHand/. Adds tests/Claudelk.Core.Tests/ (NUnit 4 on Microsoft.Testing.Platform) covering protocol byte builders, UserConfig JSON round-trip, scanner name-prefix matching, and the full byte stream each ElkBledomDevice command emits. 80 tests, dotnet test wired into the CI build job. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IBluetoothDevice/IBluetoothHostsoElkBledomScannerandElkBledomDeviceare unit-testable; production callers default to the new InTheHand adapters undersrc/Claudelk.Core/Bluetooth/InTheHand/.tests/Claudelk.Core.Tests/(NUnit 4 on Microsoft.Testing.Platform) covering protocol byte builders,UserConfigJSON round-trip, scanner name-prefix matching, and the full byte stream eachElkBledomDevicecommand emits. 80 tests total.dotnet testinto the GitHub Actions build job and switches the test project to MTP (UseMicrosoftTestingPlatformRunner=true,OutputType=Exe).Test plan
dotnet build Claudelk.slnx --configuration Release(clean — strict analyzer settings still pass)dotnet test Claudelk.slnx— 80/80 passing under MTPdotnet publish src/Claudelk.Cli -c Releaserefreshes the production exe;claudelk --helpsmoke-testedscan,pair,on,color,blink) against a real ELK-BLEDOM strip — the InTheHand adapters still need hardware verification🤖 Generated with Claude Code