Load icons lazily and fix icon-related memory leaks#638
Merged
Conversation
Icons are no longer kept in memory permanently and the GDI bitmaps created while displaying them are now disposed properly. - Remove the permanent Icon.IconBase64 cache; compute base64 on demand - Stop eagerly generating/holding IconPack.IconPackIcon previews; generate them on demand and dispose after use - Base64.GetBase64FromImage no longer disposes the caller-owned image - Dispose IconImage instances at all consumers (DeckView, ButtonEditor, IconSelector, IconPackPreview) and on form close / list reload - RoundedButton disposes its foreground (label) image on reassign/dispose - Track and dispose the on-demand pack preview in ExtensionItemView - Dispose label bitmaps in ProfileManager and ButtonLabel Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Icons are no longer kept in memory permanently and the GDI bitmaps created while displaying them are now disposed properly.