fix: Add missing importlib.util import

[matthewfeickert]

Resolves #237

Context:

• Without first importing importlib.util an AttributeError will be raised

Traceback (most recent call last):
  File "/madanalysis5/./bin/ma5", line 51, in <module>
    if not importlib.util.find_spec("six"):
           ^^^^^^^^^^^^^^
AttributeError: module 'importlib' has no attribute 'util'

Reproducer

# python --version
Python 3.11.10
# ./bin/ma5
Traceback (most recent call last):
  File "/madanalysis5/./bin/ma5", line 51, in <module>
    if not importlib.util.find_spec("six"):
           ^^^^^^^^^^^^^^
AttributeError: module 'importlib' has no attribute 'util'

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

[matthewfeickert]

@jackaraz this is ready for review.

[BFuks]

Hi @ matthewfeickert. This is actually already included in the upcoming release.

Cheers,

Benj

[matthewfeickert]

This is actually already included in the upcoming release.

@BFuks How so? This isn't on any of the [non-stale] branches. Do you not do open development?

[BFuks]

This is part of [ma5_restframes](https://github.com/MadAnalysis/madanalysis5/blob/ma5_restframes/bin/ma5), that is the next branch to be merged. Cheers, Benj

…

On 3 Dec 2024, at 20:05, Matthew Feickert ***@***.***> wrote: This is actually already included in the upcoming release. @BFuks <https://github.com/BFuks> How so? This isn't on any of the branches. Do you not do open development? — Reply to this email directly, view it on GitHub <#278 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIWJNJZFVAOVUXCGJ3QWDAD2DX6HJAVCNFSM6AAAAABS6L6RWSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMJVGM3DGNZYGY>. You are receiving this because you were mentioned.

[matthewfeickert]

Thanks @BFuks. Sorry I was only checking the branches that GitHub labels "active" (https://github.com/MadAnalysis/madanalysis5/branches/active) so I didn't see c9d1de8 as there is no associated PR for its branch.

Is there a projected timeline for a v1.10.17 release? At the moment this breaks all use.

I'm also not sure if you'd be open to getting a removal of six into v1.10.17 as well (c.f. Issue #279).

[BFuks]

We are currently finalising it, with a paper planned within the next 2-3 months. I still need to implement a couple of functionalities (mostly automatic download from hepdata for some recast codes) and we are ready to go.

In fact you are correct, let's get rid of six entirely. I will add that in the next commit! Thanks!