Skip to content

[UniformBatch] Misc fixes #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
frapac merged 4 commits into from
Jan 5, 2026
Merged

[UniformBatch] Misc fixes #81

frapac merged 4 commits into from
Jan 5, 2026

Conversation

@klamike
Copy link
Collaborator

@klamike klamike commented Dec 26, 2025 •
edited
Loading

Before merging, make a decision on klamike#2 We will implement a proper batched residual check in another PR.

This PR has:

  • post_solve! renamed check_residual!
  • fixed lack of update_jacl! in batch_initialize!
  • updated comment per frapac
  • refactored set_predictive_rhs signature

@klamike klamike requested a review from frapac December 26, 2025 23:04
@klamike klamike mentioned this pull request Dec 26, 2025
Closed
@klamike klamike changed the title Misc fixes [UniformBatch] Misc fixes Dec 26, 2025
This was referenced Dec 26, 2025
Open
Open
@frapac frapac merged commit 465d5e9 into MadNLP:batch Jan 5, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frapac frapac frapac approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@klamike @frapac