feat: enable physics on-demand for ThirdPersonControl#245
Merged
marco-ponds merged 2 commits intomasterfrom Apr 17, 2026
Merged
feat: enable physics on-demand for ThirdPersonControl#245marco-ponds merged 2 commits intomasterfrom
marco-ponds merged 2 commits intomasterfrom
Conversation
Remove the silent camera fallback from ThirdPersonControl — a target element is now required, with a clear error if missing. When physicsEnabled is requested but global physics is off, lazily initialise the physics worker and retroactively add any entities that had enablePhysics() called before the worker existed. Resolve ammo.js via MAGE_ASSETS_BASE_URL so the path works identically in local preview and production. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the silent camera fallback from ThirdPersonControl — a target element is now required, with a clear error if missing.
When physicsEnabled is requested but global physics is off, lazily initialise the physics worker and retroactively add any entities that had enablePhysics() called before the worker existed. Resolve ammo.js via MAGE_ASSETS_BASE_URL so the path works identically in local preview and production.