Skip to content

Better handling of (N)FFT operators for different NFFT backends - #264

Merged
nHackel merged 8 commits into
masterfrom
nh/fixFFTParams
Nov 11, 2025
Merged

Better handling of (N)FFT operators for different NFFT backends#264
nHackel merged 8 commits into
masterfrom
nh/fixFFTParams

Conversation

@nHackel

@nHackel nHackel commented Nov 11, 2025

Copy link
Copy Markdown
Member
  • Re-adds fftParams to NFFTOperator
  • Specialises fft parameter for backend and array type combinations
  • Adds NonuniformFFTs as second backend to test
  • With LinearOperatorCollection 2.2.1, this should mean MRIOperators is compatible with NonuniformFFTSs

@codecov

codecov Bot commented Nov 11, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 74.87%. Comparing base (5a0faa5) to head (365639c).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...IOperatorsGPUArraysExt/MRIOperatorsGPUArraysExt.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #264   +/-   ##
=======================================
  Coverage   74.86%   74.87%           
=======================================
  Files         102      103    +1     
  Lines        5415     5420    +5     
=======================================
+ Hits         4054     4058    +4     
- Misses       1361     1362    +1     
Flag Coverage Δ
MRIBase 50.19% <ø> (ø)
MRICoilSensitivities 93.07% <ø> (ø)
MRIFiles 78.59% <ø> (ø)
MRIOperators 40.18% <42.85%> (-0.01%) ⬇️
MRIReco 42.23% <57.14%> (-0.01%) ⬇️
MRISampling 0.35% <ø> (ø)
MRISimulation 63.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nHackel
nHackel merged commit 0f016b9 into master Nov 11, 2025
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant