Update operator fields to fit LinearOperators v2.13 - #273
Conversation
|
The operators themselves work, but the composition breaks at the moment because I removed type-piracy method: Base.:∘(A::AbstractLinearOperator, B::AbstractLinearOperator) = ProdOp(A, B)from LinearOperatorCollection. This currently results in certain recos constructing a function instead of a ProdOp. One solution would be to wrap the respective operators which are implemented as generic LinearOperators into custom wrappers akin to: struct FooOp <: AbstractMRIOperator
op::LinearOperator
meta:: # ...
endand then define composition for the Alternatively we could simply skip the composition operator in our reconstruction code. Time-wise I prefer the latter, but I'd really like to keep the composite op, since its just nice. I'll take another go at it tomorrow |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #273 +/- ##
===========================================
- Coverage 75.02% 59.96% -15.06%
===========================================
Files 103 101 -2
Lines 5414 5326 -88
===========================================
- Hits 4062 3194 -868
- Misses 1352 2132 +780
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Together with LinearOperatorCollection 2.4 this should fix #272