Skip to content

Add megatron-core and torchcodec to requirements.txt #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
epiccoleman wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add megatron-core and torchcodec to requirements.txt #345

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
nemo_toolkit[asr]>=2.3.0
nltk
faster-whisper>=1.1.0
git+https://github.com/MahmoudAshraf97/demucs.git
git+https://github.com/oliverguhr/deepmultilingualpunctuation.git
git+https://github.com/MahmoudAshraf97/ctc-forced-aligner.git
nemo_toolkit[asr]>=2.3.0
nltk
faster-whisper>=1.1.0
git+https://github.com/MahmoudAshraf97/demucs.git
git+https://github.com/oliverguhr/deepmultilingualpunctuation.git
git+https://github.com/MahmoudAshraf97/ctc-forced-aligner.git
megatron-core
torchcodec
Comment on lines +1 to +8

@gemini-code-assist gemini-code-assist Bot Oct 24, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Thanks for adding the dependencies needed for Apple Silicon. To improve the requirements.txt file, I have a few suggestions:

  1. Sort dependencies: It's a good practice to sort dependencies alphabetically. This makes it easier to find packages and manage the list as it grows.
  2. Pin versions: To ensure reproducible builds and prevent unexpected breakages from upstream changes, it's best to pin the versions of all dependencies (e.g., package==1.2.3). The newly added packages are not pinned. You can find the exact versions you installed by running pip freeze.
  3. Platform-specific dependencies: Since megatron-core and torchcodec are specifically for Apple Silicon, we can use environment markers to ensure they are only installed on that platform (sys_platform == 'darwin'). This avoids installing unnecessary packages for other users.
  4. Add a final newline: It's a convention to end files with a newline character.

I've provided a suggestion to sort the file and add a newline. Please also consider pinning the versions and adding environment markers where appropriate.

faster-whisper>=1.1.0
git+https://github.com/MahmoudAshraf97/ctc-forced-aligner.git
git+https://github.com/MahmoudAshraf97/demucs.git
git+https://github.com/oliverguhr/deepmultilingualpunctuation.git
megatron-core
nemo_toolkit[asr]>=2.3.0
nltk
torchcodec