Fixed admin:user:create failing when admin role has different name#592
Merged
Fixed admin:user:create failing when admin role has different name#592
admin:user:create failing when admin role has different name#592Conversation
Look up the root admin role by structure (tree_level=1) instead of hardcoding the "Administrators" name, which doesn't match databases migrated from Magento 1 / OpenMage where it's "Administrator". Fixes #586
fballiano
changed the title
admin:user:create failing when admin role has different name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"Administrators"role name lookup with a structural query (tree_level=1, ordered byrole_id ASC) so the command works regardless of the role display name"Administrator"(singular)Fixes #586
Test plan
./maho admin:user:createon a fresh install (role named "Administrators")./maho admin:user:createon a migrated database (role named "Administrator")