Skip to content

Refetch Promise Resolved #1767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Subhan-Asghar wants to merge 4 commits into
base: staging
Choose a base branch
from
Open

Refetch Promise Resolved #1767

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bbc2f42
Refetch Promise Resolved
Subhan-Asghar Jul 20, 2025
ca283cc
resolved failure of refetch
Subhan-Asghar Jul 20, 2025
35913d4
Merge branch 'Mail-0:staging' into fix/Label_Refresh
Subhan-Asghar Jul 21, 2025
59c49da
used Finally
Subhan-Asghar Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions apps/mail/components/ui/nav-main.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,9 @@ export function NavMain({ items }: NavMainProps) {
);

const onSubmit = async (data: LabelType) => {
toast.promise(createLabel(data), {
toast.promise(createLabel(data).finally(()=>{
refetch();
}), {
loading: 'Creating label...',
success: 'Label created successfully',
Copy link
Collaborator

@MrgSub MrgSub Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

toast.promise has a key finally, your promise doesn't even need to be called in the first argument

error: 'Failed to create label',
Expand Down Expand Up @@ -253,7 +255,6 @@ export function NavMain({ items }: NavMainProps) {
</Button>
}
onSubmit={onSubmit}
onSuccess={refetch}
/>
) : activeAccount?.providerId === 'microsoft' ? null : null}
</div>
Expand Down
Loading