Skip to content

Adding Traefik IngressRoute support#191

Open
abs0lom wants to merge 2 commits intoMailu:masterfrom
abs0lom:feature/add-traefik-flavor-ingress
Open

Adding Traefik IngressRoute support#191
abs0lom wants to merge 2 commits intoMailu:masterfrom
abs0lom:feature/add-traefik-flavor-ingress

Conversation

@abs0lom
Copy link
Copy Markdown

@abs0lom abs0lom commented Sep 16, 2022

I use Traefik as Ingress Controller with the IngressRoute kind provided by his CRD.

This implementation is not complete, but sufficient for my case.

You're welcome to comment this PR about missing functionalities, I'll update my work to provide more generic stuff about Traefik IngressRoute feature.

@fastlorenzo fastlorenzo added the enhancement Improvements or additions to existing features label Apr 12, 2023
@fastlorenzo
Copy link
Copy Markdown
Collaborator

@abs0lom the chart has been through a big refactor, could you maybe rebase and propose new change?

@fastlorenzo fastlorenzo added the pending answer Issues or pull requests that are awaiting a response label Apr 19, 2023
@abs0lom
Copy link
Copy Markdown
Author

abs0lom commented May 16, 2023

I just migrated my Mailu stack to version 1.2.0. As the migration was a big deal, I used the native ingress resource for the moment, using the Traefik specific annotations.

This will allow me to propose a better and more complete work than my first implementation. I will start by making a list of desirable features for traefik CRDs.

I'll work on it this weekend!

@DrPsychick
Copy link
Copy Markdown
Collaborator

I would argue that the Mailu Helm Chart should not support/include all kinds of 3rd party CRD objects.
A custom deployment could, for example, consist of a chart containing the IngressRoute and the Mailu Helm Chart as a dependency. Or the IngressRoute is simply applied separately to Kubernetes.

@fastlorenzo @promasu if you agree, I will close this.

@fastlorenzo
Copy link
Copy Markdown
Collaborator

I think we should support httproute and gateway, which would allow broader usage.
Maybe we could have a generic extraResources array in the values, that would be rendered as is, so people can include custom resources without pain

@DrPsychick
Copy link
Copy Markdown
Collaborator

Yes, that's a great idea. Gateway-api is coming either way.

So I'll close this and open an issue to support gateway-api.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improvements or additions to existing features pending answer Issues or pull requests that are awaiting a response

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants