Conversation
There was a problem hiding this comment.
ruff found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
|
going to make sure these pass tests before undrafting! |
|
Check out the contributing guide, ruff can autofix a lot |
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Can you look at doing this with requests instead? |
|
@bmos I started out trying to do it via request/bs4, but I couldn't figure out how to work out how to send the password, since it looks like they hash it in a specific way (md5 + doing other stuff to it, I think?). I'm not very well versed in web dev/auth so I could be wrong here, or looking at the wrong thing. Once authenticated, the hover and other dynamic elements made me turn to selenium, since there isn't just like a, "here's a csv link!". I can look into this more though, I think I have a few people I can ask about it. |
|
oh wait we might be able to just POST it, I think this is possible. Will update. |
…udflare, and chrome impersonation.
…w the file is saved.
|
This is looking so great! I will probably refactor it to move things around a bit and maybe some UI polish, but expect this to be merged sometime soon 🥰 |
|
I am definitely not a UI person, so I'm glad to hear that! |
Funny enough, I had already been working on a selenium script to grab periscope data, started like two weeks ago.
Here I also change the way lists are grabbed, so that we support unzipped CSV's in the filenames that periscope outputs. I also added (a bit clumsily) a button to fetch new periscope data.
New .env requirements for periscope data: PERISCOPE_URL and PERISCOPE_PASS
You can test the selenium script only by running
uv run src/fetch_list.py