Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change names for scanning external and removable storage. #62

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Inhishonor
Copy link
Contributor

@Inhishonor Inhishonor commented Apr 3, 2025

I refactored everything so it is clear from now on. It will probably need to be rebased after merging #61, sorry about that.
Closes #50

@Inhishonor Inhishonor marked this pull request as draft April 3, 2025 01:50
@Inhishonor Inhishonor force-pushed the rename-scanning-types branch 2 times, most recently from e31eafe to 60b4bc3 Compare April 3, 2025 03:11
@Inhishonor Inhishonor marked this pull request as ready for review April 3, 2025 03:14
Inhishonor

This comment was marked as resolved.

In order to improve UX by stating exactly what is being scanned, when scanning external and removable storage.
@Inhishonor Inhishonor force-pushed the rename-scanning-types branch from 8c2cce9 to e2cef44 Compare April 7, 2025 02:01
@Inhishonor
Copy link
Contributor Author

I fixed the strings so that Scan External Storage is translated and Scan Removable Storage is not. Should be good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant