Update tests - #41
Merged
Merged
Conversation
tpadioleau
requested changes
Jun 4, 2026
tpadioleau
left a comment
tpadioleau
left a comment
Member
There was a problem hiding this comment.
Do we need dedicated convergence tests for the vectorized implementations if each kernel is compared to its scalar version which has a convergence test ?
Collaborator
Author
I thought it might be useful since there are some cases that the current testsuite alone would not be able to catch all errors for example in time_step kernal. If you think its overkill I can remove it |
tpadioleau
requested changes
Jun 5, 2026
tpadioleau
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.