Open
Conversation
added 7 commits
December 31, 2014 14:57
Author
|
I'm sorry, I didn't do those commits on the master branch on purpose. I think it is now as it was in the beginning. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It really solves the issue that you tried to fix with last commit as the fallback argument is not present in Python2 (tested in 2.7.3 installed from stable repositories), as it was said in bug #13
As I am not very experienced in programming I'd like you to have a look at the work around I've used to resemble the fallback argument. What I tried to do there is to try to read the config and if it fails (because it isn't present or it is properly written) it keeps the defaults that are set at the beginning of the script.
I think I've made a bit of an unnecessary mess at the beginning because I didn't keep the finally clause, but it's just because I wrote this before your last commit was published :/ If you prefer it that way I can leave it as it was.