Skip to content

infra: metrics/docker-compose.yml still declares the obsolete top-level version key removed from root docker-compose.yml #1044

Description

@Maki-Zeninn

Description

metrics/docker-compose.yml line 1 begins with:

version: '3.8'

services:

The top-level version key in Compose files has been obsolete since Compose V2 (the docker compose CLI plugin ignores it and prints a warning: the attribute \version` is obsolete). The root docker-compose.ymlalready reflects this — it has noversion:key at all and starts directly with its header comment block beforeservices:` (line 11).

Impact

Running docker compose -f metrics/docker-compose.yml up (or any docker compose command against this file) prints an "obsolete" warning on every invocation, which is just noise, and the file is now inconsistent with the versioning convention already adopted in the root docker-compose.yml.

Suggested fix

Remove the version: '3.8' line from metrics/docker-compose.yml, matching the root docker-compose.yml:

services:
  # Metrics exporter
  router-metrics-exporter:
    ...

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions