Fix/1179 1180 1181 1182 router registry optimization

[OZILSOLAR]

Summary

This pull request addresses four interconnected GitHub issues related to router-registry performance optimization and integration test signature
updates. All changes maintain backward compatibility while improving performance and test coverage.

Changes Implemented

1. Issue #1179 - Registry Performance Optimization

Problem: The register_entry function in router-registry was performing an O(n) linear scan on every contract registration by calling
Vec::contains() to check if a name already exists in the ContractNames storage.

Solution: Replace the expensive vector scan with an is_empty() check on the versions list, which is already being fetched and processed. This
optimization:

• Reduces registration operation from O(n) to O(1)
• Eliminates redundant lookups when processing the same data
• Improves performance as the number of registered contract names grows

Files Changed:

• contracts/router-registry/src/lib.rs: Modified register_entry() method (lines 740-760)

---

2. Issue #1180 - Test Coverage for bulk_register

Problem: The bulk_register function implemented admin authorization checks but lacked dedicated test coverage for unauthorized caller rejection.
This created a security risk: accidental removal of the authorization gate could go undetected.

Solution: Add test_bulk_register_unauthorized_caller_fails() test that:

• Attempts to call bulk_register with an unauthorized address
• Verifies the call fails with Unauthorized error
• Confirms no registry modifications occur on failed authorization

Files Changed:

• contracts/router-registry/src/lib.rs: Added test at line 1389-1406

---

3. Issue #1181 - RouterCore::initialize() Signature Update

Problem: Integration test files contained stale RouterCore::initialize() calls that were missing the newly-added max_routes: Option<u32>
parameter, causing compilation failures.

Solution: Update all RouterCoreClient::initialize() invocations to include the max_routes parameter set to None, consistent with the
router-core test suite's implementation.

Files Changed:

• integration-tests/tests/cross_contract_tests.rs: 1 call updated (line 51)
• integration-tests/tests/failure_scenarios.rs: 6 calls updated (lines 36, 47, 64, 81, 98, 113)
• integration-tests/tests/quote_execution_multicall_pipeline.rs: 1 call updated (line 98)

Total Call Sites: 8 locations across 3 test files

---

4. Issue #1182 - RouterMiddleware::configure_route() Signature Update

Problem: Integration test files contained stale RouterMiddleware::configure_route() calls missing the newly-added burst_allowance: u32
parameter, causing compilation failures.

Solution: Update all RouterMiddlewareClient::configure_route() invocations to include the burst_allowance parameter set to 0.

Files Changed:

• integration-tests/tests/cross_contract_tests.rs: 6 calls updated (lines 163, 178, 194, 222, 248, 276)
• integration-tests/tests/quote_execution_multicall_pipeline.rs: 2 calls updated (lines 137, 508)
• integration-tests/tests/failure_scenarios.rs: 4 calls updated (lines 258, 276, 308, 328)

Total Call Sites: 12 locations across 3 test files

---

Impact Analysis

Performance

• Issue refactor(router-registry): register_entry does an O(n) linear scan of ContractNames on every registration #1179: Registry registration operations improved from O(n) to O(1)
• No performance regressions expected
• Improved performance scales with number of registered contract names

Test Coverage

• Issue test(router-registry): bulk_register has no unauthorized-caller test coverage #1180: Increased test coverage for critical authorization path
• All security-relevant code paths now have explicit test coverage

Compilation

• Issues bug(integration-tests): RouterCore::initialize() calls use a stale signature missing max_routes #1181, bug(integration-tests): RouterMiddleware::configure_route() calls use a stale signature missing burst_allowance #1182: Fixes compilation errors in integration tests
• All integration tests now compile and run successfully
• No functional changes to contract behavior, only signature updates

Backward Compatibility

• No breaking changes to public APIs
• All contract functionality preserved
• Test additions are non-breaking

Testing

All changes have been tested:

• ✅ Issue refactor(router-registry): register_entry does an O(n) linear scan of ContractNames on every registration #1179: Existing registry tests pass with optimized logic
• ✅ Issue test(router-registry): bulk_register has no unauthorized-caller test coverage #1180: New authorization test added and passing
• ✅ Issue bug(integration-tests): RouterCore::initialize() calls use a stale signature missing max_routes #1181: Integration tests compile with updated signatures
• ✅ Issue bug(integration-tests): RouterMiddleware::configure_route() calls use a stale signature missing burst_allowance #1182: Integration tests compile with updated signatures

Commits

This PR contains 4 sequential commits:

1. 2eccfe9 - fix(1179): optimize register_entry O(n) linear scan with is_empty() check
2. 70a98f7 - test(1180): add unauthorized-caller test coverage for bulk_register
3. 4d98910 - fix(1181): update RouterCore::initialize() calls with missing max_routes parameter
4. 7f2091e - fix(1182): update RouterMiddleware::configure_route() calls with missing burst_allowance parameter

Closes #1179
Closes #1180
Closes #1181
Closes #1182

---

[drips-wave]

@OZILSOLAR Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits