adds attribution #136
Open
adds attribution #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That seems pretty intrusive, can we shorten it and maybe add an option to show or hide attribution? |
|
for some sources is pretty short, and then I thought about shorting things up, but then NO ONE likes to be left out, not cool, so, I retained the full attribution from the providers; it might be best to include an option to hide it. |
|
hmm, maybe the fontsize could be smaller and we could have a black background (less eye catching)? |
|
Yeah on by default with option to hide might be good (but I think the full thing is good, doesn't need shortening) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very opinionated attribution banner for the map providers:
see docs preview for more examples.