Skip to content

Fixing typo in oidc authentication.conf#564

Merged
Fryguy merged 1 commit into
ManageIQ:masterfrom
ahrechushkin:master
May 9, 2025
Merged

Fixing typo in oidc authentication.conf#564
Fryguy merged 1 commit into
ManageIQ:masterfrom
ahrechushkin:master

Conversation

@ahrechushkin

Copy link
Copy Markdown
Contributor

Removed extra % symbol in authentication.conf

@miq-bot

miq-bot commented May 8, 2025

Copy link
Copy Markdown
Member

Checked commit ahrechushkin@2360f5b with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.62.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. 🏆

@Fryguy Fryguy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this is only the guides. The actual shipped changes need to be made in

@ahrechushkin Can you also make a PR to the manageiq-pods repo for the first one? Sorry - scratch that. The %% in the go code has to be that way, because it's a template. The stuff above looks fine.

cc @bdunne

@Fryguy Fryguy self-assigned this May 8, 2025
@Fryguy Fryguy added the bug label May 8, 2025
@ahrechushkin

Copy link
Copy Markdown
Contributor Author

Note that this is only the guides. The actual shipped changes need to be made in

@Fryguy, to be honest, the external authentication guide does not contain any links to the ManageIQ appliance templates. Perhaps it would make sense to add links to the actual configuration files?

For your information, I believe this pull request and this issue are related: https://github.com/orgs/ManageIQ/discussions/21893 .

@Fryguy

Fryguy commented May 9, 2025

Copy link
Copy Markdown
Member

The external auth guide (from this PR) is meant for developers who need to test against an OIDC system and are specifically pre-configured for KeyCloak to get developers up and running quickly, so this isn't a production configuration. I actually had planned for this to be moved into a container that someone could spin up locally, but I couldn't get it working that way.

@Fryguy Fryguy merged commit 819c16c into ManageIQ:master May 9, 2025
1 check passed
github-actions Bot pushed a commit to ManageIQ/manageiq.github.io that referenced this pull request May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants