Fixing typo in oidc authentication.conf#564
Conversation
|
Checked commit ahrechushkin@2360f5b with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.62.0, and yamllint |
There was a problem hiding this comment.
Note that this is only the guides. The actual shipped changes need to be made in
- (Looks ok) https://github.com/ManageIQ/manageiq-pods/blob/master/manageiq-operator/api/v1alpha1/helpers/miq-components/httpd_conf.go#L274
- (Looks ok) https://github.com/ManageIQ/manageiq-appliance/blob/master/TEMPLATE/etc/httpd/conf.d/manageiq-external-auth-openidc.conf.erb#L33
@ahrechushkin Can you also make a PR to the manageiq-pods repo for the first one? Sorry - scratch that. The %% in the go code has to be that way, because it's a template. The stuff above looks fine.
cc @bdunne
@Fryguy, to be honest, the external authentication guide does not contain any links to the ManageIQ appliance templates. Perhaps it would make sense to add links to the actual configuration files? For your information, I believe this pull request and this issue are related: https://github.com/orgs/ManageIQ/discussions/21893 . |
|
The external auth guide (from this PR) is meant for developers who need to test against an OIDC system and are specifically pre-configured for KeyCloak to get developers up and running quickly, so this isn't a production configuration. I actually had planned for this to be moved into a container that someone could spin up locally, but I couldn't get it working that way. |
Removed extra % symbol in authentication.conf