Convert react bootstrap components to carbon react#449
Conversation
GilbertCherrie
changed the title
|
Not sure how difficult or not this is, but can we do the rename in one commit and any code changes in a separate commit - it's nearly impossible to review when it's delete and change in the same commit. |
c62f2f7 to
33027e2
Compare
GilbertCherrie
changed the title
|
@Fryguy I removed the rename changes, I will add those back in a final commit / follow up pr assuming everything else here is good |
|
@miq-bot remove-label wip |
|
@asirvadAbrahamVarghese Please review. I can't assign for some reason. |
| this.props.dispatch({ | ||
| useEffect(() => { | ||
| // Initialize form buttons | ||
| dispatch({ |
There was a problem hiding this comment.
Feels like we should start using useDispatch and useSelector in React components instead of the older connect()pattern (mapStateToProps, mapDispatchToProps).
It’s a big refactor though, so we can do that later as a follow-up since everything currently uses connect().
There was a problem hiding this comment.
Yeah this should be a follow up I think
0d279dc to
d4e81ee
Compare
d4e81ee to
e00ee6e
Compare
|
@asirvadAbrahamVarghese fixed the issues if you can review again |
e00ee6e to
fbf73fc
Compare
|
Checked commits GilbertCherrie/manageiq-providers-lenovo@4fe2871~...fbf73fc with ruby 3.3.10, rubocop 1.86.0, haml-lint 0.73.0, and yamllint 1.37.1 |
5 participants
Convert the React bootstrap components to Carbon React components.
Before:
Apply Config Pattern form
Firmware Update form
After:
Apply Config Pattern form
Firmware Update form
