Feat: Enhance NetworkManager EventTargetParser targets

[niccoloalfredo]

Fix NetworkManager EventTargetParser for Neutron event payload structure

Summary

Fixes the EventTargetParser in NetworkManager to correctly extract resource IDs from Neutron events. The current implementation assumes a flat payload structure with a direct resource_id field, but Neutron uses nested payloads where resources are contained in type-specific objects.

Problem

Current behavior:

resource_id = event_payload['resource_id']  # Always returns nil for Neutron events

Actual Neutron payload structure:

{
  "payload": {
    "network": {
      "id": "b39598c6-e36e-4d8c-82c9-d295addcf82c",
      "tenant_id": "fd2f0bf534504696a8fb62ca84f4e191",
      ...
    }
  }
}

Solution

Key Changes

1. Added resource_type helper:

def resource_type
  @resource_type ||= ems_event.event_type.split(".").first
end

Extracts "network" from "network.create.end" automatically.

2. Added intelligent resource_id extraction:

def resource_id
  @resource_id ||= event_payload.dig(resource_type, "id") || event_payload["resource_id"]
end

• First tries nested structure: payload.dig("network", "id")
• Falls back to direct field for backwards compatibility

3. Replaced if/elsif chain with case statement:

target_type = case resource_type
              when "floatingip" then :floating_ips
              when "router" then :network_routers
              when "network" then :cloud_networks
              ...

4. Enhanced tenant ID extraction:

tenant_id = event_payload['tenant_id'] || 
            event_payload['project_id'] || 
            event_payload.dig(resource_type, 'tenant_id') ||
            event_payload.dig(resource_type, 'project_id') ||
            event_payload.dig('initiator', 'project_id')

Searches multiple locations for tenant/project ID in nested structures.

Testing

Manual testing with real Neutron events via AMQP:

• ✅ Networks, Subnets, Routers, Floating IPs, Security Groups, Ports
• ✅ Resource IDs correctly extracted from nested payloads
• ✅ Tenant IDs correctly extracted from nested structures
• ✅ Targeted refresh working as intended
• ✅ Security group rules (without IDs) correctly trigger full refresh

Updated spec tests:

• Payloads now reflect real Neutron structure (nested objects)
• Added tests for security group rules, fallback scenarios, and tenant extraction

---

[miq-bot]

Checked commit sourcesense@8c8a595 with ruby 3.1.7, rubocop 1.56.3, haml-lint 0.64.0, and yamllint
2 files checked, 7 offenses detected

app/models/manageiq/providers/openstack/network_manager/event_target_parser.rb

• ❗ - Line 27, Col 19 - Style/HashLikeCase - Consider replacing case-when with a hash lookup.
• ❗ - Line 61, Col 46 - Layout/TrailingWhitespace - Trailing whitespace detected.
• ❗ - Line 62, Col 47 - Layout/TrailingWhitespace - Trailing whitespace detected.
• ❗ - Line 66, Col 1 - Layout/TrailingWhitespace - Trailing whitespace detected.
• ❗ - Line 89, Col 4 - Layout/TrailingEmptyLines - Final newline missing.

spec/models/manageiq/providers/openstack/network_manager/event_target_parser_spec.rb

• ❗ - Line 194, Col 11 - Layout/HashAlignment - Align the keys and values of a hash literal if they span more than one line.
• ❗ - Line 216, Col 4 - Layout/TrailingEmptyLines - Final newline missing.

[miq-bot]

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).