Convert user form to React

[GilbertCherrie]

Fixes: and #6837, #6903, and #6904

Converted user form to React and added Cypress tests for the form.

Before:

Edit Admin User Form:

Add User Form:

Edit User Form:

Copy User Form:

After:

Edit Admin User Form:

Add User Form:

Edit User Form:

Copy User Form:

[miq-bot]

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

[kbrock]

as mentioned elsewhere, passing attributes=miq_groups will bring back the groups

[GilbertCherrie]

@elsamaryv can you please review again

[elsamaryv]

@elsamaryv can you please review again

LGTM. @jrafanie do you want to take another look at this PR?

[jrafanie]

These 3 conditional blocks look very similar. It's hard to see the difference at a glance. How is this one 👇 different then the first one ☝️? I believe the first one is actually a "edit" and the one below is a "create". The second one has no credentials change. They all say "was saved" so it's not clear. We should consider refactoring and make the differences more obvious.

[GilbertCherrie]

Yeah the first 2 branches are edit (1 with password change and 1 without) and the last one is to create user. All 3 say 'was saved' as this is what the old form did I believe.

[jrafanie]

Ok, maybe it can be refactored in a followup so it's clearer what's different. We can change what's presented in a followup if it makes sense, such as is if it's consistently done that way elsewhere.

[jrafanie]

LGTM. The other refactorings can be done in a followup.

[miq-bot]

Checked commits GilbertCherrie/manageiq-ui-classic@74105ae~...311a08c with ruby 3.3.10, rubocop 1.86.0, haml-lint 0.72.0, and yamllint 1.37.1
7 files checked, 6 offenses detected

app/controllers/ops_controller/ops_rbac.rb

• ❗ - Line 61, Col 30 - Layout/TrailingWhitespace - Trailing whitespace detected.

app/views/ops/_rbac_user_details.html.haml

• ⚠️ - Line 3 - Avoid using instance variables in partials views
• ⚠️ - Line 4 - Style/RedundantConstantBase: Remove redundant ::.
• ⚠️ - Line 8 - Avoid using instance variables in partials views
• ⚠️ - Line 8 - Line is too long. [122/80]
• ⚠️ - Line 8 - Style/RedundantParentheses: Don't use parentheses around a method call.

[jrafanie]

@GilbertCherrie I'm going to merge. I didn't notice the easy cops like trailing whitespace. Can you review and do a followup on the easy ones? Thanks!