Upgrade to cypress 15.10.x, use expose, disallow env#9837
Upgrade to cypress 15.10.x, use expose, disallow env#9837jrafanie wants to merge 1 commit intoManageIQ:masterfrom
Conversation
Replaces ManageIQ#9835 https://docs.cypress.io/app/references/changelog#15-10-0 The details around expose vs. env can be found here: https://docs.cypress.io/app/references/migration-guide#Via-runtime
|
Checked commit jrafanie@edb9f41 with ruby 3.3.10, rubocop 1.56.3, haml-lint 0.69.0, and yamllint |
| cy.then(() => { | ||
| // If waitOnlyIfRequestIntercepted is true, check if the request was intercepted | ||
| // and then wait for the response | ||
| const interceptedAliasesMap = Cypress.expose('interceptedAliases') || {}; |
There was a problem hiding this comment.
Just curious why we got rid of cy.getInterceptedApiAliases() here. Was it because it wasn’t working as expected?
I can vaguely remember this, I did return cy.getInterceptedApiAliases().then((interceptedAliasesMap)... so I could chain interceptApi for further operations (like in the selectAccordionItem command). But now it seems to work even without returning the chain from here, nice!
There was a problem hiding this comment.
Let me check. I walked 🤖 through the suggested changes. Maybe it realized it wasn't used. Let me verify before merge.
asirvadAbrahamVarghese
left a comment
asirvadAbrahamVarghese
left a comment
There was a problem hiding this comment.
Looks fine to me
3 participants
Replaces #9835
https://docs.cypress.io/app/references/changelog#15-10-0
The details around expose vs. env can be found here: https://docs.cypress.io/app/references/migration-guide#Via-runtime