Reset carbon style config#9850
Reset carbon style config#9850asirvadAbrahamVarghese wants to merge 3 commits intoManageIQ:masterfrom
Conversation
| @@ -1,8 +1,3 @@ | |||
| @use '@carbon/react/scss/themes'; | |||
| @use '@carbon/react/scss/theme' with ( | |||
| $theme: themes.$white, | |||
There was a problem hiding this comment.
The theme defaults to white, so configuration is only necessary if we want something else (like we did for menu)
|
Checked commits asirvadAbrahamVarghese/manageiq-ui-classic@071962c~...09a357d with ruby 3.3.10, rubocop 1.56.3, haml-lint 0.69.0, and yamllint |
| @use '@carbon/react' with ( | ||
| // don't break patternfly styling | ||
| $css--default-type: false, | ||
| $css--reset: false, |
There was a problem hiding this comment.
Main change here is $css--reset: false which disables carbon's aggressive style reset ⬇️
|
@GilbertCherrie Please review. @asirvadAbrahamVarghese Do you have other screenshots? Are you expecting more changes after this? |
I can capture screenshots if needed, I can also add the ones from our thread
Nope, with this change, all our non-Carbon components should look the same as they did with Carbon 10 |
4 participants
PR to restore relevant Carbon style config to prevent issues with other PatternFly components