Use Provider specific Service Templates if available#9869
Merged
Fryguy merged 1 commit intoManageIQ:masterfrom Mar 20, 2026
Merged
Conversation
agrare
commented
Feb 26, 2026
| common_st_record_vars(st) | ||
| add_orchestration_template_vars(st) if st.kind_of?(ServiceTemplateOrchestration) | ||
| add_configuration_script_vars(st) if st.kind_of?(ServiceTemplateAnsibleTower) || st.kind_of?(ServiceTemplateAwx) || st.kind_of?(ServiceTemplateTerraformEnterprise) | ||
| add_configuration_script_vars(st) if (st.kind_of?(ServiceTemplateAnsibleTower) || st.kind_of?(ServiceTemplateAwx) || st.kind_of?(ServiceTemplateTerraformEnterprise)) && @edit[:new][:st_prov_type]&.starts_with?("generic_") |
Member
Author
There was a problem hiding this comment.
This was gross already, now just worse. Need to fix this.
Member
Author
There was a problem hiding this comment.
NOTE this is only for the "deprecated" types, this will go away entirely in the new model
agrare
commented
Feb 26, 2026
| @additional_tenants = @edit[:new][:tenant_ids].map(&:to_s) # Get ids of selected Additional Tenants in the Tenants tree | ||
| available_orchestration_templates if @record.kind_of?(ServiceTemplateOrchestration) | ||
| available_automation_managers if @record.kind_of?(ServiceTemplateAnsibleTower) || @record.kind_of?(ServiceTemplateAwx) || @record.kind_of?(ServiceTemplateTerraformEnterprise) | ||
| available_automation_managers if (st.kind_of?(ServiceTemplateAnsibleTower) || st.kind_of?(ServiceTemplateAwx) || st.kind_of?(ServiceTemplateTerraformEnterprise)) && @edit[:new][:st_prov_type]&.starts_with?("generic_") |
agrare
force-pushed
the
prefer_provider_specific_service_templates_if_available
branch
2 times, most recently
from
d8b9d6d to
7a41f11
Compare
Member
Author
|
@miq-bot cross-repo-test ManageIQ/manageiq#23741 |
miq-bot
pushed a commit
to ManageIQ/manageiq-cross_repo-tests
that referenced
this pull request
Mar 4, 2026
From Pull Request: ManageIQ/manageiq-ui-classic#9869
This was referenced Mar 17, 2026
Merged
agrare
force-pushed
the
prefer_provider_specific_service_templates_if_available
branch
2 times, most recently
from
619614a to
2f84672
Compare
If a provider has a specific service template type use that before falling back on the generic `::ServiceTemplate`
agrare
force-pushed
the
prefer_provider_specific_service_templates_if_available
branch
from
2f84672 to
47f30d6
Compare
Member
|
Checked commit agrare@47f30d6 with ruby 3.3.10, rubocop 1.56.3, haml-lint 0.72.0, and yamllint 1.37.1 |
7 tasks
agrare
changed the title
agrare
deleted the
prefer_provider_specific_service_templates_if_available
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a provider has a specific service template type use that before falling back on the generic
::ServiceTemplateThis allows for some of the specific features like seeing Plays and Stdout from AWX/AnsiblePlaybook services in the UI
Depends on:
Awx Service provisioned with workflows provision.asl:
Embedded Terraform Service provisioned with workflows:
Embedded Ansible Service provisioned with workflows:
ManageIQ/manageiq#23775