Skip to content

[WIP] Build credential grid for selecting credential_id for ConfigurationScript provisioning#9930

Closed
putmanoj wants to merge 1 commit into
ManageIQ:masterfrom
putmanoj:build_credential_grid_for_mig_provision
Closed

[WIP] Build credential grid for selecting credential_id for ConfigurationScript provisioning#9930
putmanoj wants to merge 1 commit into
ManageIQ:masterfrom
putmanoj:build_credential_grid_for_mig_provision

Conversation

@putmanoj

@putmanoj putmanoj commented Mar 26, 2026

Copy link
Copy Markdown
Contributor

Comment thread app/helpers/request_info_helper.rb Outdated
def prov_grid_list(data)
data[:none_index] = "__#{data[:type].to_s.upcase}__NONE__"
send("prov_#{data[:type]}_data", data)
send(:"prov_#{data[:type]}_data", data)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look necessary

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The IDE prettifier is to blame, reverted more of others, this got left out.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted the line

@putmanoj putmanoj force-pushed the build_credential_grid_for_mig_provision branch from 0bf2342 to e829a76 Compare March 26, 2026 16:35
@miq-bot

miq-bot commented Mar 26, 2026

Copy link
Copy Markdown
Member

Checked commit putmanoj@e829a76 with ruby 3.3.10, rubocop 1.86.0, haml-lint 0.72.0, and yamllint 1.37.1
4 files checked, 8 offenses detected

app/controllers/application_controller/miq_request_methods.rb

app/helpers/request_info_helper.rb

app/views/miq_request/_prov_configuration_script_dialog.html.haml

  • ⚠️ - Line 53 - Layout/HashAlignment: Align the keys and values of a hash literal if they span more than one line.
  • ⚠️ - Line 54 - Layout/HashAlignment: Align the keys and values of a hash literal if they span more than one line.
  • ⚠️ - Line 55 - Layout/HashAlignment: Align the keys and values of a hash literal if they span more than one line.
  • ⚠️ - Line 56 - Layout/HashAlignment: Align the keys and values of a hash literal if they span more than one line.
  • ⚠️ - Line 57 - Layout/HashAlignment: Align the keys and values of a hash literal if they span more than one line.

@putmanoj putmanoj marked this pull request as ready for review March 26, 2026 17:44
@putmanoj putmanoj requested a review from a team as a code owner March 26, 2026 17:44
@miq-bot

miq-bot commented May 14, 2026

Copy link
Copy Markdown
Member

This pull request is not mergeable. Please rebase and repush.

@agrare

agrare commented May 14, 2026

Copy link
Copy Markdown
Member

Closing in favor of #9950

@agrare agrare closed this May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants