Skip to content

Upgrade @carbon/react to latest#9936

Merged
Fryguy merged 2 commits into
ManageIQ:masterfrom
asirvadAbrahamVarghese:upgrade-@carbon/react
Apr 13, 2026
Merged

Upgrade @carbon/react to latest#9936
Fryguy merged 2 commits into
ManageIQ:masterfrom
asirvadAbrahamVarghese:upgrade-@carbon/react

Conversation

@asirvadAbrahamVarghese

@asirvadAbrahamVarghese asirvadAbrahamVarghese commented Mar 30, 2026

Copy link
Copy Markdown
Contributor

Replaces #9924

PR to bump @carbon/react to v1.104.0

@asirvadAbrahamVarghese asirvadAbrahamVarghese requested a review from a team as a code owner March 30, 2026 11:11
asirvadAbrahamVarghese
asirvadAbrahamVarghese commented Mar 30, 2026
View reviewed changes
Comment thread .babelrc.js
require('@babel/plugin-transform-class-properties').default,
require('@babel/plugin-transform-optional-chaining').default,
require('@babel/plugin-transform-nullish-coalescing-operator').default,
require('@babel/plugin-transform-numeric-separator').default,

@asirvadAbrahamVarghese asirvadAbrahamVarghese Mar 30, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Numeric separators (4_294_967_295) are modern syntax, so adding this plugin to transform them.

Otherwise, webpack will fail to compile:
Image

@asirvadAbrahamVarghese

asirvadAbrahamVarghese commented Mar 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Current Jest failures with the error Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: object are due to an issue in version 1.104.0 (see related issue: #21896).
image

This has been fixed in 1.104.1-rc.1, we’re just waiting for the full release

@asirvadAbrahamVarghese

asirvadAbrahamVarghese commented Mar 30, 2026

Copy link
Copy Markdown
Contributor Author

Jest ran fine on 1.104.1-rc.1
image

@asirvadAbrahamVarghese asirvadAbrahamVarghese changed the title [WIP] - Upgrade @carbon/react to latest Upgrade @carbon/react to latest Mar 30, 2026
@asirvadAbrahamVarghese

asirvadAbrahamVarghese commented Apr 10, 2026

Copy link
Copy Markdown
Contributor Author

V105 is out - will bump the PR, go through changes and do a quick UI test again

@asirvadAbrahamVarghese asirvadAbrahamVarghese changed the title Upgrade @carbon/react to latest [WIP] - Upgrade @carbon/react to latest Apr 10, 2026
@miq-bot miq-bot added the wip label Apr 10, 2026
@asirvadAbrahamVarghese asirvadAbrahamVarghese changed the title [WIP] - Upgrade @carbon/react to latest Upgrade @carbon/react to latest Apr 13, 2026
@miq-bot

miq-bot commented Apr 13, 2026

Copy link
Copy Markdown
Member

Checked commits asirvadAbrahamVarghese/manageiq-ui-classic@7a77635~...b14cc50 with ruby 3.3.10, rubocop 1.86.0, haml-lint 0.72.0, and yamllint 1.37.1
0 files checked, 0 offenses detected
Everything looks fine. 🍪

@miq-bot miq-bot removed the wip label Apr 13, 2026
@Fryguy Fryguy merged commit 309d813 into ManageIQ:master Apr 13, 2026
11 checks passed
@Fryguy Fryguy self-assigned this Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fryguy Fryguy Fryguy approved these changes

Assignees

@Fryguy Fryguy

Labels

dependencies

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@asirvadAbrahamVarghese @miq-bot @Fryguy