Skip yarn for plugins with no dependencies#9999
Open
asirvadAbrahamVarghese wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Seems to have worked fine: |
asirvadAbrahamVarghese
force-pushed
the
enhance-ui-setup-task
branch
from
dbb5e4b to
d248569
Compare
Fryguy
reviewed
Apr 22, 2026
Comment on lines
+20
to
+23
| # Log yarn version being used | ||
| yarn_version = `yarn --version`.strip | ||
| puts " Yarn version: #{yarn_version}" | ||
|
|
Member
There was a problem hiding this comment.
This part is actually not necessary, because Yarn itself will emit it's version when we run it.
Member
|
What does this actually save us, now that I think about it. Unless we remove yarn/yarn.lock/package.json, then all this does is really trim down the amount of text, right? |
Contributor
Author
|
Yeah, it might look like that, but we don’t need to remove But like I said, if we’re planning to add test/lint packages or anything at plugin level soon, then there’s probably no point in doing this now. |
asirvadAbrahamVarghese
force-pushed
the
enhance-ui-setup-task
branch
from
d248569 to
85cf386
Compare
Member
|
Some comments on commit asirvadAbrahamVarghese@85cf386 lib/tasks/manageiq/ui_tasks.rake
|
Member
|
Checked commit asirvadAbrahamVarghese@85cf386 with ruby 3.3.10, rubocop 1.86.0, haml-lint 0.73.0, and yamllint 1.37.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR to skip
yarnstep for plugins with no dependencies or devDependencies. In such cases, running Yarn doesn’t serve any purpose. As a follow-up, we can also remove yarn and engines from those plugins, reducing maintenance overhead and avoiding repeated upgrade PRs.