Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Drop manageiq-consumption (showback) #22496

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Fryguy
Copy link
Member

@Fryguy Fryguy commented May 4, 2023

Just wanted to put up a super rough, very WIP, PR for removing the manageiq-consumption (i.e. showback) plugin.

Note that after this PR, git grep and ag with -i metering and -i showback return nothing of relevance across all repos (aside from the known TODO below).

Depends on

TODO:

  • Remove schema
  • cross-repo-test, particularly with ui and api
  • Verify manual chargeback runs and add specs for anything missing.
  • MOAR deletions
    • Settings.product.consumption used on the UI side
  • Archive manageiq-consumption repo

cc @kbrock

@miq-bot
Copy link
Member

miq-bot commented May 4, 2023

Checked commits Fryguy/manageiq@087ea4d~...5eb4c42 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
14 files checked, 0 offenses detected
Everything looks fine. ⭐

@Fryguy
Copy link
Member Author

Fryguy commented May 5, 2023

@miq-bot cross-repo-test /all including ManageIQ/manageiq-ui-classic#8780

miq-bot pushed a commit to ManageIQ/manageiq-cross_repo-tests that referenced this pull request May 5, 2023
@Fryguy
Copy link
Member Author

Fryguy commented May 5, 2023

This might be a little too aggressive - I don't think Metering is related to the showback code as metering sounds like chargeback reports but without the cost part.

@miq-bot
Copy link
Member

miq-bot commented Jun 13, 2023

This pull request is not mergeable. Please rebase and repush.

@kbrock kbrock mentioned this pull request Mar 6, 2023
29 tasks
@miq-bot miq-bot added the stale label Sep 18, 2023
@miq-bot miq-bot closed this Sep 18, 2023
@miq-bot
Copy link
Member

miq-bot commented Sep 18, 2023

This pull request has been automatically closed because it has not been updated for at least 3 months.

Feel free to reopen this pull request if these changes are still valid.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

@Fryguy Fryguy reopened this Sep 18, 2023
@Fryguy Fryguy added pinned and removed stale labels Sep 18, 2023
@miq-bot
Copy link
Member

miq-bot commented Sep 18, 2023

This pull request is not mergeable. Please rebase and repush.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants