Rails 7.1 #23225

jrafanie · 2024-10-07T22:45:09Z

Update gem dependencies for rails 7.1
Drop legacy connection handler option previously disabled
Use new schema migration interface
Explicitly set YAML default column serializer to avoid having to set coder everywhere
Update Arel::Table usage
Allow concurrent-ruby 1.3.5+ (wasn't fixed in rails 7.0)
Use new broadcast logging API
Load Rails 7.1 defaults with exceptions for tests that fail
- Here's the list of the changes for defaults in 7.0 and 7.1: https://github.com/rails/rails/blob/v7.1.5.1/railties/lib/rails/application/configuration.rb#L219-L331

Waiting on 💚 cross repo after pulling in virtual attributes release.

config/application.rb

Fryguy · 2025-02-18T21:15:09Z

config/application.rb

@@ -135,6 +154,8 @@ class Application < Rails::Application

    config.autoload_once_paths << Rails.root.join("lib/vmdb/console_methods.rb").to_s

+    config.active_record.default_column_serializer = YAML if Rails.version >= "7.1"


Does this require a change like #23253 but choosing the serializer? If not, what is the default on 7.1+ that we need to get to?

Yes.

https://www.github.com/rails/rails/pull/47422 is the original... in it, he wanted to remove the default of YAML for all applications.

That was scaled back to only do this for new applications, ones that load_defaults 7.1. It's supposed to require a coder specified if you don't have a default.

The one that landed is this one: https://www.github.com/rails/rails/pull/47463

I had that info in a commit message but must have lost it when squashing/rebasing.

ok, pushed updated commit message in badad1f

Oh ok, honestly I didn't read any commit messages since you had code comments for a number of things.

Gemfile

jrafanie · 2025-02-18T23:35:03Z

spec/models/service_spec.rb

+      #   \
+      #    @service_c1 -> [@vm1]
+      #      \
+      #       @service_c2 -> [@vm1, @vm2]


I needed this picture to understand the setup above 😉

jrafanie · 2025-02-18T23:35:19Z

spec/models/service_spec.rb

-        service = Service.select(:id, :v_total_vms).find_by(:id => @service.id)
-        expect(service.v_total_vms).to eq 4
-        expect(service.attribute_present?(:v_total_vms)).to eq true
+        #TODO: This is how rails 7.0 worked... not sure why v_total_vms is 1 for @service_c1!


Note, 7.1.5 is the minimum as it's supposed to fix alias_attribute on user defined methods instead only the generated methods for rails attributes. It's unclear if it fixes all the issues as you can call alias_attribute anywhere up the ancestry tree and it's possible lazy loading is preventing them from being loaded. See: https://www.github.com/rails/rails/issues/52820 https://www.github.com/rails/rails/pull/52842 (7.1 backport: https://www.github.com/rails/rails/pull/52844) Looks like it's still an issue in some situations: https://www.github.com/rails/rails/issues/50154 https://www.github.com/rails/rails/issues/51717

In ManageIQ#23171, we found that we weren't using the legacy connection handlers and disabled using them in rails 7.0. Now, in 7.1, this option has been removed, so it's safe to remove this option entirely.

https://www.github.com/rails/rails/pull/45908

Originally, in https://www.github.com/rails/rails/pull/47422, they wanted to remove the default of YAML for all applications. It would be nil. That was scaled back to only do this for new applications. Namely, ones that call load_defaults 7.1. It's supposed to require a coder specified if you don't have a default. The one that landed is this one: https://www.github.com/rails/rails/pull/47463

Rails 7.1 removed the table_name alias to name so just use name: See: https://www.github.com/rails/rails/pull/46864 Rails 7.1 removed the writer for the table_alias, but you can provide an "as" argument to Arel::Table.new, which does an alias. See: https://www.github.com/rails/rails/pull/48927

This reverts commit e4fa809. This is not supposed to be needed in rails 7.1

We no longer need to wrap loggers as you can inspect all broadcasted loggers and automatically send the same log level or other method calls to each. We added a wrap method to wrap a logger with a broadcaster in: ManageIQ/manageiq-loggers#63 See also: https://www.github.com/rails/rails/pull/48615

https://github.com/rails/rails/blob/d437ae311f1b9dc40b442e40eb602e020cec4e49/railties/lib/rails/application/configuration.rb#L92 * belongs_to_required_by_default must be overridden or seeding fails * Partial inserts cause test failures in ui-classic, content, and amazon provider * Once we remove unsafe-inline, then we can set this to the default, 0. Since we still use unsafe-inline, we still use X-XSS-Protection. * Allow deprecations to be found and fixed Fixes ManageIQ#23172

Note, cache_format_version is backward compatible: New versions can read old versions. During rolling deployments old versions would not be able to read new versions so you must upgrade code first, then, they'll be able to read old or new versions. For us, we always deploy code first and restart so changing formats to the latest will not be a problem. See also: https://www.github.com/rails/rails/pull/48122

jrafanie · 2025-02-19T16:30:23Z

config/application.rb

-    # See: https://guides.rubyonrails.org/upgrading_ruby_on_rails.html#new-activesupport-cache-serialization-format
-    warn "Warning: Remove redundant config.active_support.cache_format_version = 7.0 from #{__FILE__}:#{__LINE__ + 1} if using config.load_defaults 7.0" if config.active_support.cache_format_version == 7.0
-    config.active_support.cache_format_version = 7.0
-


From the the commit message:

Note, cache_format_version is backward compatible:
New versions can read old versions. During rolling deployments
old versions would not be able to read new versions so you must
upgrade code first, then, they'll be able to read old or new versions.

For us, we always deploy code first and restart so changing formats to
the latest will not be a problem.

See also: https://www.github.com/rails/rails/pull/48122

miq-bot · 2025-02-19T16:30:49Z

Checked commits jrafanie/manageiq@13c571e~...9deac23 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
10 files checked, 1 offense detected

config/application.rb

❗ - Line 115, Col 5 - Style/MethodCallWithArgsParentheses - Use parentheses for method calls with arguments.

Fryguy

🎉

jrafanie requested a review from Fryguy as a code owner October 7, 2024 22:45

jrafanie changed the title ~~[WIPRails71~~ [WIP] Rails71 Oct 7, 2024

jrafanie added enhancement wip rails7.1 labels Oct 7, 2024

jrafanie force-pushed the rails71 branch 2 times, most recently from 8888823 to 35c7f80 Compare October 7, 2024 22:53

miq-bot added the dependencies label Oct 7, 2024

jrafanie force-pushed the rails71 branch from 534cb5d to c7e275a Compare October 8, 2024 14:17

jrafanie mentioned this pull request Oct 10, 2024

Support rails 7.1 #23200

Closed

56 tasks

jrafanie force-pushed the rails71 branch from c7e275a to a1834c0 Compare October 10, 2024 17:33

jrafanie requested review from agrare and kbrock as code owners October 10, 2024 17:33

miq-bot added the unmergeable label Oct 16, 2024

jrafanie force-pushed the rails71 branch from a1834c0 to a759a77 Compare October 23, 2024 22:47

jrafanie mentioned this pull request Oct 29, 2024

Rails 4? Remove long since deprecated bridge monkey patch #23247

Merged

1 task

jrafanie force-pushed the rails71 branch 2 times, most recently from 95c915c to 728da06 Compare October 29, 2024 19:37

This was referenced Oct 30, 2024

Fix deprecations using activesupport deprecation #23249

Merged

Fix positional argument deprecations with ERB.new #23250

Merged

miq-bot removed the unmergeable label Oct 31, 2024

This was referenced Nov 1, 2024

Use the rails 7.1+ serialize interface #23253

Merged

Use Rails.application.credentials instead of deprecated secrets #23254

Merged

jrafanie force-pushed the rails71 branch from 728da06 to 72581af Compare November 7, 2024 14:47

jrafanie force-pushed the rails71 branch from 72581af to 1b0c5a9 Compare November 20, 2024 22:14

jrafanie force-pushed the rails71 branch from 1b0c5a9 to fe9ba76 Compare December 12, 2024 17:03

jrafanie force-pushed the rails71 branch from 8342b1c to fbfcdff Compare January 3, 2025 20:30

jrafanie mentioned this pull request Jan 3, 2025

Remove unnecessary test failing on rails 7.1. #23299

Merged

jrafanie force-pushed the rails71 branch 2 times, most recently from 0eb4c64 to ea2d65d Compare January 7, 2025 23:01

Fryguy reviewed Feb 18, 2025

View reviewed changes

config/application.rb Show resolved Hide resolved

Fryguy reviewed Feb 18, 2025

View reviewed changes

jrafanie force-pushed the rails71 branch 4 times, most recently from b1e51a6 to fe33d2a Compare February 18, 2025 23:21

jrafanie commented Feb 18, 2025

View reviewed changes

Gemfile Outdated Show resolved Hide resolved

jrafanie commented Feb 18, 2025

View reviewed changes

jrafanie force-pushed the rails71 branch from fe33d2a to b2f89d7 Compare February 19, 2025 14:35

jrafanie added 7 commits February 19, 2025 11:12

Drop already disabled legacy option rails 7.1 disallows

c882f42

In ManageIQ#23171, we found that we weren't using the legacy connection handlers and disabled using them in rails 7.0. Now, in 7.1, this option has been removed, so it's safe to remove this option entirely.

Use new interface for SchemaMigration in 7.1

1ceebe3

https://www.github.com/rails/rails/pull/45908

Revert "Pin concurrent-ruby to < 1.3.5"

ba95506

This reverts commit e4fa809. This is not supposed to be needed in rails 7.1

jrafanie force-pushed the rails71 branch from b2f89d7 to 46b3986 Compare February 19, 2025 16:15

jrafanie force-pushed the rails71 branch from 46b3986 to 45723ac Compare February 19, 2025 16:23

jrafanie force-pushed the rails71 branch from 45723ac to 9deac23 Compare February 19, 2025 16:29

jrafanie commented Feb 19, 2025

View reviewed changes

jrafanie changed the title ~~[WIP] Rails71~~ Rails 7.1 Feb 19, 2025

jrafanie removed the wip label Feb 19, 2025

Fryguy approved these changes Feb 19, 2025

View reviewed changes

Fryguy merged commit f232310 into ManageIQ:master Feb 19, 2025
8 checks passed

jrafanie deleted the rails71 branch February 19, 2025 17:31

jrafanie assigned Fryguy Feb 19, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rails 7.1 #23225

Rails 7.1 #23225

jrafanie commented Oct 7, 2024 •

edited

Loading

Fryguy Feb 18, 2025

jrafanie Feb 18, 2025 •

edited

Loading

jrafanie Feb 18, 2025 •

edited

Loading

Fryguy Feb 19, 2025

jrafanie Feb 18, 2025

jrafanie Feb 18, 2025

jrafanie Feb 19, 2025

miq-bot commented Feb 19, 2025 •

edited by jrafanie

Loading

Fryguy left a comment

		@@ -135,6 +154,8 @@ class Application < Rails::Application

		config.autoload_once_paths << Rails.root.join("lib/vmdb/console_methods.rb").to_s

		config.active_record.default_column_serializer = YAML if Rails.version >= "7.1"

Rails 7.1 #23225

Rails 7.1 #23225

Conversation

jrafanie commented Oct 7, 2024 • edited Loading

Fryguy Feb 18, 2025

Choose a reason for hiding this comment

jrafanie Feb 18, 2025 • edited Loading

Choose a reason for hiding this comment

jrafanie Feb 18, 2025 • edited Loading

Choose a reason for hiding this comment

Fryguy Feb 19, 2025

Choose a reason for hiding this comment

jrafanie Feb 18, 2025

Choose a reason for hiding this comment

jrafanie Feb 18, 2025

Choose a reason for hiding this comment

jrafanie Feb 19, 2025

Choose a reason for hiding this comment

miq-bot commented Feb 19, 2025 • edited by jrafanie Loading

Fryguy left a comment

Choose a reason for hiding this comment

jrafanie commented Oct 7, 2024 •

edited

Loading

jrafanie Feb 18, 2025 •

edited

Loading

jrafanie Feb 18, 2025 •

edited

Loading

miq-bot commented Feb 19, 2025 •

edited by jrafanie

Loading