Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rugged to 1.9.0 #23353

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Bump rugged to 1.9.0 #23353

merged 1 commit into from
Feb 26, 2025

Conversation

Fryguy
Copy link
Member

@Fryguy Fryguy commented Feb 26, 2025

Rugged 1.6.2 fixes a Ruby 3.2+ issue where warnings were emitted of the form

warning: undefining the allocator of T_DATA class Rugged::Repository

See libgit2/rugged#935
Spassky run with the warnings: https://github.com/ManageIQ/manageiq/actions/runs/13552984631/job/37880823140#step:8:24

This was seen in the specs that used spec/support/fake_git_repo.rb and lib/git_worktree.rb.

@jrafanie Please review.

Rugged 1.6.2 fixes a Ruby 3.2+ issue where warnings were emitted of the
form

```
warning: undefining the allocator of T_DATA class Rugged::Repository
```

This was seen in the specs that used spec/support/fake_git_repo.rb and
lib/git_worktree.rb.
@Fryguy
Copy link
Member Author

Fryguy commented Feb 26, 2025

@miq-bot cross-repo-test manageiq-providers-workflows, manageiq-automation_engine, manageiq-providers-embedded_terraform

miq-bot pushed a commit to ManageIQ/manageiq-cross_repo-tests that referenced this pull request Feb 26, 2025
@jrafanie
Copy link
Member

merging, 💚 cross repo

@jrafanie jrafanie merged commit 787a223 into ManageIQ:master Feb 26, 2025
8 checks passed
@Fryguy Fryguy deleted the bump_rugged branch February 27, 2025 14:40
Fryguy pushed a commit that referenced this pull request Feb 28, 2025
Bump rugged to 1.9.0

(cherry picked from commit 787a223)
Fryguy added a commit that referenced this pull request Feb 28, 2025
@Fryguy
Copy link
Member Author

Fryguy commented Feb 28, 2025

Manually backported to spassky in b7a9e13 and 8548d5e

commit 8548d5eb09b9e3b9334404c15a805904576ae987 (HEAD -> spassky, upstream/spassky)
Author: Jason Frey <[email protected]>
Date:   Fri Feb 28 14:18:28 2025 -0500

    Bump Gemfile.lock.release after backport of #23353

commit b7a9e136ed1697e26fc4c2c0ab334df4732461e0
Author: Joe Rafaniello <[email protected]>
Date:   Wed Feb 26 17:51:05 2025 -0500

    Merge pull request #23353 from Fryguy/bump_rugged

    Bump rugged to 1.9.0

    (cherry picked from commit 787a223fcda8ec7ee93e6239c283e3d76c377a6b)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants