test preload passing an array

[kbrock]

No description provided.

[jrafanie]

hosts? plural?

  1) MiqPreloader.preload preloads association array
     Failure/Error: ActiveRecord::Associations::Preloader.new(:records => Array(records), :associations => associations, :scope => preload_scope).call

     ActiveRecord::AssociationNotFoundError:
       Association named 'host' was not found on ManageIQ::Providers::Vmware::InfraManager; perhaps you misspelled it?
     # ./lib/miq_preloader.rb:25:in `preload'
     # ./spec/lib/miq_preloader_spec.rb:115:in `preload'
     # ./spec/lib/miq_preloader_spec.rb:108:in `block (4 levels) in <top (required)>'
     # ./spec/lib/miq_preloader_spec.rb:108:in `block (3 levels) in <top (required)>'

[kbrock]

ugh. thnx

[jrafanie]

See test failure above

[kbrock]

ok, so this is failing on trying to preload the host in the ems.

To me it looks like it is flattening the preload hash into just an array.
From what I can tell, this is correct behavior.

My concern:
I found code that I think expects different behavior:

manageiq $ ag 'preload\([^)]*=>'

app/models/storage.rb
692:        MiqPreloader.preload(self, :vms => :storage_files_files)

app/models/manageiq/providers/cloud_manager/metrics_capture.rb
6:    MiqPreloader.preload([ems], :vms => [{:availability_zone => :tags}, :ext_management_system])

app/models/manageiq/providers/container_manager/metrics_capture.rb
5:    MiqPreloader.preload([ems], :container_images => :tags, :container_nodes => :tags, :container_groups => [:tags, {:containers => :tags}])

[kbrock]

@jrafanie update:

• fixed association to update with hash and array

update:

• fixed test to compare correct values

This should be good to go

[jrafanie]

My concern:
I found code that I think expects different behavior:

sorry, what was the resolution of this @kbrock ?

[kbrock]

@jrafanie all set. it successfully handles hash and array - it was a bad test/misunderstood failure.

This is validating our expectations successfully