Revert "Update dependency gettext_i18n_rails_js to "~>1.4.0"" #23584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4aeed7a.
Member
|
What's weird is you didn't see these changes locally. I'm curious why not |
Member
Author
I was concentrating on the po to json patch and the upgrade of po to json gem... I was not looking a the result of running update_all as I thought the bot or a manual run here would test it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 4aeed7a, #23566
#23583 is showing some changes we didn't expect. We will need to verify the patches as we upgrade as we have patches in our locale.rake, gettext_task_overide.rb, and po_to_json_override.rb, and possibly elsewhere so we'll need to remove/changes things when we do the upgrade in #23580
For now, let's just revert.