[WIP] Switch ActsAsArModel to be QueryRelation based by default

[Fryguy]

This flips ActsAsArModel to be search-first (i.e. via QueryRelation) and deprecates the old-style find method that takes :all, :first, or :last (However, find with an id is still supported just like in Rails). This also deprecates the old-style find_by_id and find_all_by_id.

WIP: I think I should change the default implementation of PglogicalSubscription#search to handle where :id - right now it can't handle it.

cc @kbrock

[Fryguy]

This deprecation was moved into the base class.

[kbrock]

I don't think we use find_by_id anymore. I did find in a few spots, but they look rare.
Maybe your search shows more callers (to any class)

[Fryguy]

Interestingly no deprecations showed up in the tests...let's see what cross repo shows

@miq-bot cross-repo-test /all

[kbrock]

yea, think we can drop support for find(:all).

We have no callers and only class implements this interface

[kbrock]

Think we can be more yolo here.

The interface for QueryRelation is search. We decided to convert that to legacy find, for all of our AAArM implementations, but since PglogicalSubscription is the only class that implemented find(), lets just fix it in the one place and not keep around the legacy find support and all.

I am a little concerned that Chargebacks and VimPerformanceTrends do not properly implement the AAArM interface, but it looks like reports call a custom method to run those reports. (i.e.: trend.rb )

Don't feel we should keep dead weight in our interface when we don't have anything using that interface (except for pglogical)

[Fryguy]

Yeah I was concerned maybe something was using that old interface that's why I added the deprecations but nothing showing up as deprecations so I don't think it's used

[kbrock]

Just a grep across the org for 'self.find\b' really speaks for itself.
(and then doing the same for search - which is also basically nada)

possibly interesting

def self.find(*args) manageiq:pglogical_subscription.rb:19
def self.find(*_args) manageiq:acts_as_ar_model.rb:149
def self.search(mode, options = {}) manageiq:acts_as_ar_model.rb:156
def find(*args) manageiq-api-client:collection.rb:35
def search(mode, options) manageiq-api-client:collection.rb:80

not interesting

def self.search(str) manageiq:miq_ae_instance.rb:80
def self.search(*args) manageiq:filterer.rb:176
def search(options = {}) manageiq:filterer.rb:226
def self.search(*args) manageiq:rbac.rb:2
def search(opts, &blk) manageiq:miq_ldap.rb:155
def search(object_ref = nil, options = {}) manageiq-automation_engine:miq_ae_browser.rb:43
def find(id) manageiq-automation_engine:miq_ae_service_front.rb:9
def self.find(id) manageiq-automation_engine:miq_ae_service.rb:21
def search(uri, namespace, klass, instance, method) manageiq-automation_engine:miq_ae_domain_search.rb:26
def find(collection, lookup_pairs) manageiq-providers-openstack:interaction_methods.rb:25
def find(obj) manageiq-providers-vmware:cache.rb:25
def find(dir, depth = nil, level = 0) manageiq-smartstate:MiqFS.rb:241
def find(name) manageiq-smartstate:attrib_index_root.rb:108
def self.find(path, max_depth = nil) manageiq-smartstate:find_class_methods.rb:51

[miq-bot]

This pull request is not mergeable. Please rebase and repush.

[kbrock]

This is a great change. It would be a shame not get it in.

[kbrock]

Really think we can drop this. The only place we use it is in PgLogical (as mentioned in the previous list). This will remove legacy_options and a lot of other stuff. (Not sure the legacy options even work in current versions of Rails.)

[kbrock]

I don't think we use find_by_id anymore. I did find in a few spots, but they look rare.
Maybe your search shows more callers (to any class)