[WIP] Replace top level ems factories dummy provider

Gemfile

@@ -330,4 +330,5 @@ group :development, :test do
   gem "parallel_tests",                 "~>4.4",    :require => false
   gem "routes_lazy_routes"
   gem "rspec-rails",                    "~>7.0"
+  manageiq_plugin "manageiq-providers-dummy_provider"
 end

spec/factories/ext_management_system.rb

@@ -1,6 +1,6 @@
 FactoryBot.define do
   factory :ext_management_system,
-          :class   => "ManageIQ::Providers::Vmware::InfraManager" do
+          :class   => "ManageIQ::Providers::DummyProvider::InfraManager" do
     # The provider has to be set before the hostname/ipaddress sequences as in some cases these attributes
     # might be delegated to the provider. As the attributes are being set based on the order in this file,
     # it is important to keep this line at the beginning of the factory.
@@ -75,38 +75,31 @@
   # using leaf classes...
   factory :ems_infra,
           :aliases => ["manageiq/providers/infra_manager"],
-          :class   => "ManageIQ::Providers::Vmware::InfraManager",
+          :class   => "ManageIQ::Providers::DummyProvider::InfraManager",
           :parent  => :ext_management_system
 
   factory :ems_physical_infra,
           :aliases => ["manageiq/providers/physical_infra_manager"],
-          :class   => "ManageIQ::Providers::Redfish::PhysicalInfraManager",
+          :class   => "ManageIQ::Providers::DummyProvider::PhysicalInfraManager",
           :parent  => :ext_management_system
 
   factory(:ems_cloud,
           :aliases => ["manageiq/providers/cloud_manager"],
-          :class   => "ManageIQ::Providers::Amazon::CloudManager",
+          :class   => "ManageIQ::Providers::DummyProvider::CloudManager",
           :parent  => :ext_management_system) do
     provider_region { "us-east-1" }
   end
 
   factory :ems_network,
           :aliases => ["manageiq/providers/network_manager"],
-          :class   => "ManageIQ::Providers::Openstack::NetworkManager",
+          :class   => "ManageIQ::Providers::DummyProvider::NetworkManager",
           :parent  => :ext_management_system do
     parent_manager { FactoryBot.create(:ext_management_system) }
   end
 
   factory :ems_storage,
           :aliases => ["manageiq/providers/storage_manager"],
-          :class   => "ManageIQ::Providers::Openstack::StorageManager::SwiftManager",
-          :parent  => :ext_management_system do
-    parent_manager { FactoryBot.create(:ext_management_system) }
-  end
-
-  factory :ems_cinder,
-          :aliases => ["manageiq/providers/storage_manager/cinder_manager"],
-          :class   => "ManageIQ::Providers::Openstack::StorageManager::CinderManager",
+          :class   => "ManageIQ::Providers::DummyProvider::StorageManager",
           :parent  => :ext_management_system do
     parent_manager { FactoryBot.create(:ext_management_system) }
   end
@@ -118,21 +111,14 @@
     parent_manager { FactoryBot.create(:ext_management_system) }
   end
 
-  factory :ems_swift,
-          :aliases => ["manageiq/providers/storage_manager/swift_manager"],
-          :class   => "ManageIQ::Providers::Openstack::StorageManager::SwiftManager",
-          :parent  => :ext_management_system do
-    parent_manager { FactoryBot.create(:ext_management_system) }
-  end
-
   factory :ems_container,
           :aliases => ["manageiq/providers/container_manager"],
-          :class   => "ManageIQ::Providers::Openshift::ContainerManager",
+          :class   => "ManageIQ::Providers::DummyProvider::ContainerManager",
           :parent  => :ext_management_system
 
   factory :configuration_manager,
           :aliases => ["manageiq/providers/configuration_manager"],
-          :class   => "ManageIQ::Providers::Foreman::ConfigurationManager",
+          :class   => "ManageIQ::Providers::DummyProvider::ConfigurationManager",
           :parent  => :ext_management_system do
     provider :factory => :provider_foreman
   end
@@ -141,12 +127,12 @@
 
   factory :automation_manager,
           :aliases => ["manageiq/providers/automation_manager"],
-          :class   => "ManageIQ::Providers::Awx::AutomationManager",
+          :class   => "ManageIQ::Providers::DummyProvider::AutomationManager",
           :parent  => :ext_management_system
 
   factory :provisioning_manager,
           :aliases => ["manageiq/providers/provisioning_manager"],
-          :class   => "ManageIQ::Providers::Foreman::ProvisioningManager",
+          :class   => "ManageIQ::Providers::DummyProvider::ProvisioningManager",
           :parent  => :ext_management_system do
     provider :factory => :provider_foreman
   end

spec/lib/manageiq/deep_delete_spec.rb

@@ -1,11 +1,11 @@
 RSpec.describe ManageIQ::DeepDelete do
-  let(:ems) { FactoryBot.create(:ems_container) }
+  let(:ems)       { FactoryBot.create(:ems_container) }
   let(:ems_other) { FactoryBot.create(:ems_container) }
 
   it "calls destroy for objects with ruby callbacks" do
-    expect_any_instance_of(ems.class).to receive(:destroy)
-
     described_class.delete(ems)
+    expect(ems).to be_deleted
+    expect(ems_other).not_to be_deleted
   end
 
   it "deletes Ems#has_many" do

spec/models/ext_management_system_spec.rb

@@ -127,7 +127,7 @@
   end
 
   it "does access database when unchanged model is saved" do
-    r = FactoryBot.create(:ems_vmware)
+    r = FactoryBot.create(:ems_infra)
     expect { r.valid? }.to make_database_queries(:count => 3)
   end
 
@@ -147,13 +147,13 @@
   end
 
   it "validates type" do
-    v = FactoryBot.create(:ems_vmware)
-    e = FactoryBot.create(:ext_management_system)
-    s = FactoryBot.create(:ems_storage)
+    infra   = FactoryBot.create(:ems_infra)
+    network = FactoryBot.create(:ems_network)
+    storage = FactoryBot.create(:ems_storage)
 
-    expect([v.valid?, v.emstype]).to eq([true, 'vmwarews'])
-    expect([e.valid?, e.emstype]).to eq([true, 'vmwarews'])
-    expect([s.valid?, s.emstype]).to eq([true, 'swift'])
+    expect([infra.valid?,   infra.emstype]).to   eq([true, 'dummy_provider_infra'])
+    expect([network.valid?, network.emstype]).to eq([true, 'dummy_provider_network'])
+    expect([storage.valid?, storage.emstype]).to eq([true, 'dummy_provider_storage'])
     expect { ManageIQ::Providers::BaseManager.new(:hostname => "abc", :name => "abc", :zone => FactoryBot.build(:zone)).validate! }.to raise_error(ActiveRecord::RecordInvalid)
     expect { ManageIQ::Providers::InfraManager.new(:hostname => "abc", :name => "abc", :zone => FactoryBot.build(:zone)).validate! }.to raise_error(ActiveRecord::RecordInvalid)
     expect { ManageIQ::Providers::CloudManager.new(:hostname => "abc", :name => "abc", :zone => FactoryBot.build(:zone)).validate! }.to raise_error(ActiveRecord::RecordInvalid)

spec/models/manageiq/providers/cloud_manager/provision_workflow_spec.rb

@@ -2,7 +2,7 @@
   include Spec::Support::WorkflowHelper
 
   let(:admin) { FactoryBot.create(:user_with_group) }
-  let(:ems) { FactoryBot.create(:ems_cloud) }
+  let(:ems) { FactoryBot.create(:ems_amazon) }
   let(:network_manager) { ems.network_manager }
   let(:template) { FactoryBot.create(:miq_template, :name => "template", :ext_management_system => ems) }
 

spec/models/manageiq/providers/inventory/persister/local_db_finders_spec.rb

@@ -14,7 +14,7 @@
   ######################################################################################################################
   #
   before do
-    @ems = FactoryBot.create(:ems_cloud)
+    @ems = FactoryBot.create(:ems_amazon)
   end
 
   before do

spec/models/manageiq/providers/inventory/persister/serializing_spec.rb

@@ -11,7 +11,7 @@
   ######################################################################################################################
   #
   before do
-    @ems = FactoryBot.create(:ems_cloud)
+    @ems = FactoryBot.create(:ems_amazon)
   end
 
   it "tests we can serialize inventory object with nested lazy references" do