Skip to content

Update CodeQL settings to be closer to the default#23715

Merged
jrafanie merged 2 commits intoManageIQ:masterfrom
Fryguy:resetup-codeql
Jan 30, 2026
Merged

Update CodeQL settings to be closer to the default#23715
jrafanie merged 2 commits intoManageIQ:masterfrom
Fryguy:resetup-codeql

Conversation

@Fryguy
Copy link
Copy Markdown
Member

@Fryguy Fryguy commented Jan 30, 2026

@jrafanie Please review. I recently added CodeQL default to all repos in the org, but this one had a custom config. So, I manually switched it to default, but we need the special config to ignore the generator templates. However, when I tried to switch it back, it does like the old file name. As such, this PR updates codeql settings to be closer to the default.

Some changes:

  • Dropped spec from the scanning as that's closer to the default - I kind of also want to see what it finds
  • Added actions as a scan language as that's in the default too.
  • Inlined the configuration

You can see the diff better in the second commit.

@miq-bot
Copy link
Copy Markdown
Member

miq-bot commented Jan 30, 2026

Checked commits Fryguy/manageiq@c63ddec~...30a7103 with ruby 3.1.7, rubocop 1.56.3, haml-lint 0.64.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. 🏆

Copy link
Copy Markdown
Member

@jrafanie jrafanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrafanie jrafanie merged commit f25fb94 into ManageIQ:master Jan 30, 2026
7 checks passed
@Fryguy Fryguy deleted the resetup-codeql branch February 5, 2026 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants