[WIP] Move default server roles out of Settings#23717
[WIP] Move default server roles out of Settings#23717agrare wants to merge 1 commit intoManageIQ:masterfrom
Conversation
| end | ||
|
|
||
| def ensure_default_roles | ||
| MiqServer.my_server.add_settings_for_resource(:server => {:role => ENV["MIQ_SERVER_DEFAULT_ROLES"]}) if role.blank? && ENV["MIQ_SERVER_DEFAULT_ROLES"].present? |
There was a problem hiding this comment.
NOTE this env var was added in https://github.com/ManageIQ/manageiq/pull/15470/changes#diff-cbd3ec3e096cbe173ed3536046e328fd0350c56f9fcbdd90f14e255d506022c3R58 but it doesn't appear to have ever been used
| :limit: 5 | ||
| :period: 20.seconds | ||
| :role: database_operations,event,reporting,scheduler,smartstate,ems_operations,ems_inventory,ems_metrics_collector,ems_metrics_coordinator,ems_metrics_processor,notifier,user_interface,remote_console,web_services,automate | ||
| :role: |
There was a problem hiding this comment.
This is replaced by ServerRole.default_roles
From Pull Request: ManageIQ/manageiq#23717
agrare
force-pushed
the
move_server_role_default_from_settings_to_column
branch
from
1584fd3 to
ddd8857
Compare
|
|
||
| def sync_assigned_roles | ||
| self.role = ::Settings.server.role | ||
| self.role = ::Settings.server.role if ::Settings.server.role |
There was a problem hiding this comment.
::Settings.server.role can be nil now, not sure if we want to set ::Settings.server.role = server_role_names.join(",") or handle there not being any SettingsChanges for server.role
We still need to use Settings.server.role for the UI to configure roles for now at least.
agrare
force-pushed
the
move_server_role_default_from_settings_to_column
branch
3 times, most recently
from
e1c262c to
1e43936
Compare
agrare
force-pushed
the
move_server_role_default_from_settings_to_column
branch
from
1e43936 to
7f412b6
Compare
|
Checked commit agrare@7f412b6 with ruby 3.3.10, rubocop 1.56.3, haml-lint 0.69.0, and yamllint |
2 participants
Add a
:defaultcolumn toServerRoleso that we do not need to useSettings.server.roleto indicate if a role should be enabled by default or not.This allows for plugins to bring default server roles.
Depends on:
ServerRole#defaultto replace Settings.server.role manageiq-schema#829Related: