Add ServiceTemplate.class_from_prov_type to hide the complexity of finding a ServiceTemplate class#23789
Merged
Fryguy merged 3 commits intoManageIQ:masterfrom Mar 31, 2026
Conversation
Unify the various approaches to getting a ServiceTemplate class given a prov_type string.
1 task
agrare
changed the title
ServiceTemplate.class_from_prov_type to hide the complexity of finding a ServiceTemplate class
agrare
commented
Mar 31, 2026
agrare
commented
Mar 31, 2026
Comment on lines
+160
to
+161
| class_name = "ServiceTemplate#{prov_type.camelize}" | ||
| class_name = "ServiceTemplate" unless allowed_class_names.include?(class_name) |
Member
Author
There was a problem hiding this comment.
TODO would love to enforce provider subclasses of ServiceTemplates and Services so this can follow the same rules as the generic_ case above
Fryguy
reviewed
Mar 31, 2026
agrare
force-pushed
the
add_service_template_class_from_prov_type
branch
from
697dc2a to
f6d9914
Compare
Fryguy
approved these changes
Mar 31, 2026
Member
|
I agree with rubocop here. |
agrare
force-pushed
the
add_service_template_class_from_prov_type
branch
from
f6d9914 to
ec3302b
Compare
Member
|
Checked commits agrare/manageiq@b87b3d0~...ec3302b with ruby 3.3.10, rubocop 1.86.0, haml-lint 0.72.0, and yamllint 1.37.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unify the various approaches to getting a ServiceTemplate class given a prov_type string.
Dependents: