Skip to content

[NEEDS CODE REVIEWER] (time-out related) Adding timeout property to instances.#346

Open
eadgbear wants to merge 2 commits into
ManiMatter:devfrom
eadgbear:eadgbear/timeout_fix
Open

[NEEDS CODE REVIEWER] (time-out related) Adding timeout property to instances.#346
eadgbear wants to merge 2 commits into
ManiMatter:devfrom
eadgbear:eadgbear/timeout_fix

Conversation

@eadgbear

@eadgbear eadgbear commented Apr 19, 2026

Copy link
Copy Markdown

My instances are a bit overloaded, so adding some timeout parameters to them would be really useful for me

@ManiMatter

Copy link
Copy Markdown
Owner

hi @eadgbear

many thanks for your PR.

I am very much under water and can't spend time on decluttarr much more. Therefore, I am looking for contributors who can help maintain & review code. Would you be willing to start co-developing decluttarr together with whomever signs up otherwise?

That would be highly appreciated. Then the next person who will join can look into this PR, and would highly apprecaite if you could look at some of the existing ones (for example #333, which also deals with request timeout).

Thanks for letting me know.

Comment thread config/config_example.yaml
@ManiMatter ManiMatter changed the title Adding timeout property to instances. [NEEDS CODE REVIEWER] Adding timeout property to instances. Apr 21, 2026
@ManiMatter ManiMatter changed the title [NEEDS CODE REVIEWER] Adding timeout property to instances. [NEEDS CODE REVIEWER] (time-out related) Adding timeout property to instances. Apr 21, 2026
@eadgbear

Copy link
Copy Markdown
Author

hi @eadgbear

many thanks for your PR.

I am very much under water and can't spend time on decluttarr much more. Therefore, I am looking for contributors who can help maintain & review code. Would you be willing to start co-developing decluttarr together with whomever signs up otherwise?

That would be highly appreciated. Then the next person who will join can look into this PR, and would highly apprecaite if you could look at some of the existing ones (for example #333, which also deals with request timeout).

Thanks for letting me know.

I'm willing to give it my best!

@ManiMatter

Copy link
Copy Markdown
Owner

Awesome, thank you for volunteering. I just gave you contributor access.

@lolimmlost

Copy link
Copy Markdown
Collaborator

Hey @eadgbear, Thanks for contributing! I am reviewing as part of clearing the open PR backlog with @ManiMatter.

The per-instance timeout is real value:
Threading timeout through every make_request site for arr + qbit + sabnzbd is the kind of plumbing nobody wants to do but somebody had to. Tests look thorough.

Heads-up — overlap with #333:
#333 also adds general.request_timeout (same name, same default of 15s) plus the missing crash-handling half that issue #317 actually complains about. They'll conflict on merge — only one can introduce that setting.

Suggested path: wait for #333 to land (closes #329 and #317, two high-prio bugs), then rebase this on top to drop the duplicated general.request_timeout bits and keep just the per-instance override layer. Users get both: global default + per-instance override. Happy to help if the rebase is messy.

Linkage: worth referencing #317 in the body — this addresses one half of it (configurable timeout), even if #333 ends up the merged closer.
@ManiMatter any thoughts on this?

@ManiMatter

Copy link
Copy Markdown
Owner

@lolimmlost - Sounds like a good strategy, agree.

@ManiMatter

Copy link
Copy Markdown
Owner

@eadgbear - I see that your invite to become a collaborator has expired:
image
Let me resend a new invite to you. Please have a a look if you receive it, if not, please let me know!

@ManiMatter

Copy link
Copy Markdown
Owner

@eadgbear .. ping? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants