-
Notifications
You must be signed in to change notification settings - Fork 53
Support qBittorrent 5.2 API key authentication #367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to also add
a) an error that qbit needs to be updated for api key to be supported (if api_key and qbitversion < 5.2)?
b) a recommendation to switch from password to api key (if (username or password) and qbitversion >= 5.2)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, both are useful, with one limitation:
a) If api_key is configured and we successfully retrieve a qBittorrent version below 5.2, we should warn that the configured API key is unsupported and is not providing authentication. We should not fail the application or remove support for older qBittorrent versions.
If the initial Bearer request returns 403, we cannot retrieve the version because /app/version itself requires authentication. That response can mean either an invalid key on 5.2+ or an older server without API-key support, so the existing combined troubleshooting message remains necessary.
b) If username/password is configured and the retrieved version is 5.2+, we can reliably log an informational recommendation to switch to an API key while continuing normally.
I’ll add both post-version guidance checks without changing the existing qBittorrent 4.3 minimum or making API keys mandatory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry - forgot to post that earlier. Anywho:
Updated in 701f67f. Added the post-version warning for API key + qBittorrent below 5.2 and the recommendation for username/password + qBittorrent 5.2+. These are guidance-only and do not change supported versions or authentication behavior. The existing ambiguous-403 handling remains unchanged. All 37 relevant tests pass. Ready for re-review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me