-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[F] Implement PG search filtering #3826
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26a87c9
to
6d07cbe
Compare
6d07cbe
to
ae6c881
Compare
6f153f1
to
4af2d63
Compare
ff13d3c
to
22585a6
Compare
scryptmouse
requested changes
Mar 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! I think putting one abstraction in would be beneficial to build off of.
992c560
to
f72ff2b
Compare
45bf388
to
29c0178
Compare
scryptmouse
approved these changes
Mar 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is continuing to look good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a separate Filtering applicator that supports using the
pg_search
gem rather thansearchkick
. It also modifies several models to supportpg_search
based filtering. Currentlypg_search
can be activated in an environment by setting an environment variable 'USE_PG_SEARCH' to true.See the apply_spec.rb for a list of currently supported models
Models that do not need to support
pg_search
because they already implement customby_keyword
:Some Notes / Important differences from Searchkick:
name
that we alias in rails withalias name title
, we need to pass pg_searchname
, nottitle
. This also means that fields liketitle_plaintext
are unavailable. They could be implemented as a PG function, however.Possible Improvements: