Skip to content

Fix failing version detection when path contains spaces #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025
Merged

Fix failing version detection when path contains spaces #131

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/manimVersion.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { exec } from "child_process";

import { Window, Logger } from "./logger";
import * as vscode from "vscode";
import { Logger, Window } from "./logger";

/**
* Manim version that the user has installed without the 'v' prefix,
Expand Down Expand Up @@ -159,7 +159,7 @@ export async function determineManimVersion(pythonBinary: string | undefined) {
}, 3000);
});

const versionCommand = `${pythonBinary} -c \"from importlib.metadata import version; `
const versionCommand = `"${pythonBinary}" -c \"from importlib.metadata import version; `
+ " print(version('manimgl'))\"";

try {
Expand Down