Skip to content

Organize imports (via TypeScript lint) #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 14, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -91,12 +91,14 @@
"ensurepip",
"github",
"glxinfo",
"importlib",
"ipython",
"Keybord",
"kisak",
"laggy",
"libglut",
"libpango",
"logfile",
"Logfile",
"manim",
"Manim",
Expand Down
10 changes: 6 additions & 4 deletions src/export.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
import * as vscode from "vscode";
import { window, TextDocument, CancellationToken, CodeLens } from "vscode";
import { CancellationToken, CodeLens, TextDocument, window } from "vscode";
import { Logger, Window } from "./logger";
import { ManimClass } from "./pythonParsing";
import {
MultiStepInput, toQuickPickItems, shouldResumeNoOp,
MultiStepInput,
shouldResumeNoOp,
toQuickPickItems,
} from "./utils/multiStepQuickPickUtil";
import { ManimClass } from "./pythonParsing";
import { Logger, Window } from "./logger";
import { waitNewTerminalDelay } from "./utils/terminal";

class VideoQuality {
Expand Down
17 changes: 8 additions & 9 deletions src/extension.ts
Original file line number Diff line number Diff line change
@@ -1,18 +1,17 @@
import { EventEmitter } from "events";
import * as vscode from "vscode";
import { window } from "vscode";
import { ManimShell, NoActiveShellError } from "./manimShell";
import { exportScene, ExportSceneCodeLens } from "./export";
import { Logger, LogRecorder, Window } from "./logger";
import { ManimCell } from "./manimCell";
import { previewManimCell, reloadAndPreviewManimCell, previewCode } from "./previewCode";
import { startScene, exitScene } from "./startStopScene";
import { exportScene } from "./export";
import { Logger, Window, LogRecorder } from "./logger";
import { registerWalkthroughCommands } from "./walkthrough";
import { ExportSceneCodeLens } from "./export";
import { ManimShell, NoActiveShellError } from "./manimShell";
import { determineManimVersion } from "./manimVersion";
import { setupTestEnvironment } from "./utils/testing";
import { EventEmitter } from "events";
import { applyWindowsPastePatch } from "./patches/applyPatches";
import { previewCode, previewManimCell, reloadAndPreviewManimCell } from "./previewCode";
import { exitScene, startScene } from "./startStopScene";
import { setupTestEnvironment } from "./utils/testing";
import { getBinaryPathInPythonEnv } from "./utils/venv";
import { registerWalkthroughCommands } from "./walkthrough";

export let manimNotebookContext: vscode.ExtensionContext;

Expand Down
9 changes: 4 additions & 5 deletions src/logger.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
import * as vscode from "vscode";
import { window } from "vscode";
import { LogOutputChannel } from "vscode";
import { waitUntilFileExists, revealFileInOS } from "./utils/fileUtil";
import * as path from "path";
import * as fs from "fs";
import * as os from "os";
import * as path from "path";
import * as vscode from "vscode";
import { LogOutputChannel, window } from "vscode";
import { revealFileInOS, waitUntilFileExists } from "./utils/fileUtil";

const LOGGER_NAME = "Manim Notebook";

Expand Down
8 changes: 6 additions & 2 deletions src/manimCell.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
import * as vscode from "vscode";
import { window, TextDocument, CancellationToken,
CodeLens, FoldingContext, FoldingRange } from "vscode";
import {
CancellationToken,
CodeLens, FoldingContext, FoldingRange,
TextDocument,
window,
} from "vscode";
import { ManimCellRanges } from "./pythonParsing";

export class ManimCell implements vscode.CodeLensProvider, vscode.FoldingRangeProvider {
Expand Down
2 changes: 1 addition & 1 deletion src/patches/applyPatches.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { exec } from "child_process";
import * as fs from "fs";
import path from "path";
import { exec } from "child_process";

import { Logger, Window } from "../logger";

Expand Down
6 changes: 3 additions & 3 deletions src/previewCode.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import { EventEmitter } from "events";
import * as vscode from "vscode";
import { window } from "vscode";
import { ManimShell } from "./manimShell";
import { EventEmitter } from "events";
import { ManimCellRanges } from "./pythonParsing";
import { Logger, Window } from "./logger";
import { ManimShell } from "./manimShell";
import { hasUserMinimalManimVersionAndWarn } from "./manimVersion";
import { ManimCellRanges } from "./pythonParsing";

// \x0C: is Ctrl + L, which clears the terminal screen
const PREVIEW_COMMAND = "\x0Ccheckpoint_paste()";
Expand Down
4 changes: 2 additions & 2 deletions src/startStopScene.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import * as vscode from "vscode";
import { ManimShell, NoActiveShellError } from "./manimShell";
import { window, workspace } from "vscode";
import { Logger, Window } from "./logger";
import { ManimClass } from "./pythonParsing";
import { ManimShell, NoActiveShellError } from "./manimShell";
import { hasUserMinimalManimVersion } from "./manimVersion";
import { ManimClass } from "./pythonParsing";

/**
* Runs the `manimgl` command in the terminal, with the current cursor's
Expand Down
2 changes: 1 addition & 1 deletion src/utils/fileUtil.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import * as vscode from "vscode";
import * as fs from "fs";
import * as path from "path";
import * as vscode from "vscode";

/**
* Waits until a file exists on the disk.
Expand Down
6 changes: 5 additions & 1 deletion src/utils/multiStepQuickPickUtil.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
import {
QuickPickItem, window, Disposable, QuickInputButton, QuickInput, QuickInputButtons,
Disposable,
QuickInput,
QuickInputButton,
QuickInputButtons,
QuickPickItem, window,
} from "vscode";

export function toQuickPickItem(names: string): QuickPickItem {
Expand Down
2 changes: 1 addition & 1 deletion src/utils/testing.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { window, Terminal, TerminalShellExecution } from "vscode";
import * as path from "path";
import { Terminal, TerminalShellExecution, window } from "vscode";
import { stripAnsiCodes } from "./terminal";

export function setupTestEnvironment() {
Expand Down
6 changes: 3 additions & 3 deletions src/walkthrough.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import * as vscode from "vscode";
import { ExtensionContext, window, workspace, commands } from "vscode";
import { Logger } from "./logger";
import fs from "fs";
import path from "path";
import * as vscode from "vscode";
import { commands, ExtensionContext, window, workspace } from "vscode";
import { Logger } from "./logger";

export function registerWalkthroughCommands(context: ExtensionContext) {
const openSampleFileCommand = commands.registerCommand(
Expand Down
8 changes: 3 additions & 5 deletions tests/activation.test.ts
Original file line number Diff line number Diff line change
@@ -1,15 +1,13 @@
import { window, commands } from "vscode";
import { commands, window } from "vscode";

import { describe, it, before, afterEach } from "mocha";
import { afterEach, before, describe, it } from "mocha";
import * as sinon from "sinon";
let expect: Chai.ExpectStatic;

import { manimNotebookContext } from "../src/extension";
import { Logger } from "../src/logger";
import { applyWindowsPastePatch } from "../src/patches/applyPatches";
import { manimNotebookContext } from "../src/extension";

// eslint-disable-next-line no-unused-vars
import * as manimNotebook from "../src/extension";
import { onTerminalOutput } from "../src/utils/terminal";

const MANIM_VERSION_STRING_REGEX = /v\d+\.\d+\.\d+/;
Expand Down
6 changes: 3 additions & 3 deletions tests/preview.test.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import { window, commands } from "vscode";
import { describe, it, before } from "mocha";
import { before, describe, it } from "mocha";
import { commands, window } from "vscode";
import { goToLine } from "./utils/editor";
import { onAnyTerminalOutput } from "./utils/terminal";
import { uriInWorkspace } from "./utils/testRunner";
import { goToLine } from "./utils/editor";
let expect: Chai.ExpectStatic;

before(async () => {
Expand Down
2 changes: 1 addition & 1 deletion tests/utils/editor.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { TextEditor, Selection } from "vscode";
import { Selection, TextEditor } from "vscode";

/**
* Moves the cursor to the specified line number.
Expand Down
2 changes: 1 addition & 1 deletion tests/utils/installManim.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { ManimInstaller } from "./manimInstaller";
import * as path from "path";
import { ManimInstaller } from "./manimInstaller";

async function setupManimInstallation() {
const baseFolder = process.cwd();
Expand Down
2 changes: 1 addition & 1 deletion tests/utils/manimCaller.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { window } from "vscode";
import * as path from "path";
import { window } from "vscode";

export class ManimCaller {
public venvPath: string = "";
Expand Down
6 changes: 3 additions & 3 deletions tests/utils/testRunner.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,14 @@
// import as soon as possible
import { activatedEmitter } from "../../src/extension";

import * as path from "path";
import Mocha from "mocha";
import * as assert from "assert";
import { globSync } from "glob";
import Mocha from "mocha";
import * as path from "path";
import "source-map-support/register";
import "./prototype";

import { window, workspace, Uri, extensions } from "vscode";
import { Uri, extensions, window, workspace } from "vscode";

const WORKSPACE_ROOT: string = workspace.workspaceFolders![0].uri.fsPath;

Expand Down