Prevent infinite stroke_width array nesting in OpenGL VMObject #4178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update mapping of the width parameter to an array, such that updating with the current value repeatedly does not cause an infinite nesting issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Explanation: Why and how do your changes improve the library?
This is an attempt to solve #4097
Further Information and Comments
To be honest I'm not sure what kind of values can be assigned to stroke_width. Based on the methods I've seen it should be just a float. Internally I see that we need an array, but then maybe the internal representation shouldn't be used externally (only via a property). I'm not familiar enough with the repo, but this seemed like a small change. Let me know if this would break anything.
Reviewer Checklist