Fixing a bug with label color in graph not applying. #4188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TestScene.mp4Better with colors, compare with actual documentation https://docs.manim.community/en/stable/reference/manim.mobject.graph.Graph.html#labeledmodifiedgraph |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
Fixes a bug with label color in Graph Mobject being always white (the default color for MathTex) because of wrong argument name.
Motivation and Explanation: Why and how do your changes improve the library?
I like to have good argument names so we can actually use it haha.
Links to added or changed documentation pages
Further Information and Comments
Actually I thought my last PR with 4 lines diff would be the smallest I do, but this one is actually smaller. Maybe I'll manage to make a 1 line PR at some point.
Reviewer Checklist