Fix Line
failing with buff
and path_arc
(issue #4132)
#4193
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
Fixes issue: #4132
Motivation and Explanation: Why and how do your changes improve the library?
Issue Explanation
When
buff
is given,Line
internally calls:(see:
pointwise_become_partial
in Line)Since
vmobject
isself
, modifyingself.points
also modifiesvmobject.points
.This leads to a problem in the code (lines 1942-1949 and beyond),
where
self.points = np.empty(...)
also affectsvmobject.points
, erasing the data before it is used.Solution
Before setting
self.points = np.empty(...)
, we first make a copy ofvmobject.points
to ensure we are working with valid data.
Reviewer Checklist