add get_entry and get_entry_without_label to table#4697
Open
nitzan-treg wants to merge 1 commit intoManimCommunity:mainfrom
Open
add get_entry and get_entry_without_label to table#4697nitzan-treg wants to merge 1 commit intoManimCommunity:mainfrom
nitzan-treg wants to merge 1 commit intoManimCommunity:mainfrom
Conversation
added two new methods to the table class -- `get_entry(pos)` and `get_entry_without_label(pos)` -- that return a single vmobject at the given position. they just delegate to the existing `get_entries` and `get_entries_without_labels` methods so nothing breaks, but now you have dedicated single-entry methods with proper explicit return types instead of the weird union return on the plural methods. the original methods are untouched for backward compat. Signed-off-by: nitzan-treg <nitzan.tregerman@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview: What does this pull request change?
hey, trying to fix #2051
added two new methods to the Table class --
get_entry(pos)andget_entry_without_label(pos)-- that return a single VMobject at the given position. they just delegate to the existingget_entriesandget_entries_without_labelsmethods so nothing breaks, but now you have dedicated single-entry methods with proper explicit return types instead of the weird union return on the plural methods. the original methods are untouched for backward compat.Motivation and Explanation: Why and how do your changes improve the library?
Links to added or changed documentation pages
Further Information and Comments
Reviewer Checklist